[Bug 184291] Review Request: gnokii - a mobile telephone manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnokii - a mobile telephone manager


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184291


ville.skytta at iki.fi changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ville.skytta at iki.fi




------- Additional Comments From ville.skytta at iki.fi  2006-03-08 02:04 EST -------
As I'm intimately familiar with the package, it might be useful if someone else
would review this.  However, if nobody picks it up by Friday, I will do it.

Some initial comments anyway:

If the smsd-sql patch is the same as in my old package, the comment is
misleading.  It does not create the database because everything in the patch is
commented out; it's just for documentation purposes.

I think it's safe to drop the Obsoletes: in xgnokii.

Including xgnokii.pc in xgnokii doesn't seem right.  It should probably be moved
to gnokii-devel.  Or if not, xgnokii should have a dependency on pkgconfig.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.