[Bug 184305] Review Request: ftnchek - Static analyzer for Fortran 77 programs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ftnchek - Static analyzer for Fortran 77 programs


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=184305


pertusus at free.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |pertusus at free.fr




------- Additional Comments From pertusus at free.fr  2006-03-08 06:28 EST -------
1. The RPM CFLAGS are not set. Here is a sed one-liner that solves that. You may
prefer a patch, do what you prefer:

sed -i -e 's/CFLAGS="-DUNIX.*"//' configure

2. you don't install the emacs stuff. Not a big deal. If you want to package it,
you may want to have them in a subpackage ftncheck-emacs. Here is how I do to
have the emacs files in the buildroot:

mkdir -p $RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp
%makeinstall datadir=$RPM_BUILD_ROOT%{_datadir}/ftnchek \
   lispdir=$RPM_BUILD_ROOT%{_datadir}/emacs/site-lisp

3. I prefer something like
%{_mandir}/man1/dcl2inc.1*
instead of 
%{_mandir}/man1/dcl2inc.1.gz
such that it works if man pages are no gzipped, or are bzip2ed and so on. It is
my personal taste

4. you should add FAQ and PATCHES in %doc

Please fix 1. and 4., and do whatever you like with 2. and 3.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.