fish on current devel

[Axel Liljencrantz]

Hi Oliver,

On 3/10/06, Oliver Falk <oliver at linux-kernel.at> wrote:
> Hi Axel!
>
> Fish needs a new aquarium. :-) Just joking... It urgently needs a
> rebuild, but there's a problem at the moment:

I was aware of the problem with the dependencies in the spec file,
I've mailed fedora-extras-devel asking about what package replaces
xorg-x11-devel twice, but I did not get any reply. Thankfully, it
seems Michael Schwendt was nice enough to post a patch to this list
below.

The other problem,

>
> It seems to be a gcc 4 related problem, as with gcc 3.2 it works.
>
> However, to be included in devel, it must build with the actual system
> wide default compiled: gcc 4.1.0.
>
> Latest try on my FC devel box:
>
> make[1]: Entering directory
> `/var/hosting/INTERNAL/LKERNAT/home/oliver/cvs/Fedora/extras/mine/fish/devel/fish-1.21.2'
> gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
> -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386
> -mtune=generic -fasynchronous-unwind-tables -Wall
> -fno-optimize-sibling-calls   -c -o function.o function.c
> In file included from function.c:14:
> fallback.h:34: error: expected declaration specifiers or '...' before
> numeric constant
> fallback.h:34: error: conflicting types for '__fwprintf_chk'
> /usr/include/bits/wchar2.h:223: error: previous declaration of
> '__fwprintf_chk' was here
> fallback.h:44: error: expected declaration specifiers or '...' before
> numeric constant
> fallback.h:44: error: expected ')' before '!=' token
> fallback.h:53: error: expected declaration specifiers or '...' before
> numeric constant
> fallback.h:53: error: conflicting types for '__wprintf_chk'
> /usr/include/bits/wchar2.h:225: error: previous declaration of
> '__wprintf_chk' was here
> fallback.h:62: error: expected declaration specifiers or '...' before
> numeric constant
> fallback.h:62: error: conflicting types for '__vwprintf_chk'
> /usr/include/bits/wchar2.h:230: error: previous declaration of
> '__vwprintf_chk' was here
> fallback.h:71: error: expected declaration specifiers or '...' before
> numeric constant
> fallback.h:71: error: conflicting types for '__vfwprintf_chk'
> /usr/include/bits/wchar2.h:228: error: previous declaration of
> '__vfwprintf_chk' was here
> fallback.h:80: error: expected declaration specifiers or '...' before
> numeric constant
> fallback.h:80: error: expected ')' before '!=' token
> function.c: In function 'function_remove':
> function.c:204: warning: dereferencing type-punned pointer will break
> strict-aliasing rules
> make[1]: *** [function.o] Error 1
> make[1]: Leaving directory
> `/var/hosting/INTERNAL/LKERNAT/home/oliver/cvs/Fedora/extras/mine/fish/devel/fish-1.21.2'
> error: Bad exit status from /var/tmp/rpm-tmp.34420 (%build)
>
>
> Please have a look and let me know.

I've looked into this, and I am completely baffled at how this can
build without as much as a warning on FC4 and every other system I've
tried it on - it clearly uses a type inside a function prototype
before the type is typedef:ed. I'll put out 1.21.3 fixing this.
Unfortunatly I do not have access to a FC5 box, so I can't verify that
this works. I've made a test version available that moves this typedef
from common.h to fallback.h, as it  belongs. If you could verify that
this works on FC5, I'd be happy to release it at once:

http://roo.no-ip.org/fish/fish-1.21.3.tar.bz2
http://roo.no-ip.org/fish/fish.spec

(I can't build these into a src.rpm because I don't have FC5 and FC4
has different build deps)

>
> Best,
>   Oliver
>


--
Axel