[Bug 185221] Review Request: wifiroamd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: wifiroamd


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185221





------- Additional Comments From ed at eh3.com  2006-03-12 00:58 EST -------
Hi Jafo, heres a quick review:

good:
 + naming OK
 + license (GPL) is OK
 + builds in mock on FC4
 + rpmlint reports:
      W: wifiroamd conffile-without-noreplace-flag 
       /etc/wifiroamd/config-defaults
   which is probably safe to ignore
 + source matches upstream
 + no unnecessary BuildRequires
 + spec file is clean, legible, and has consistent macros
 + code not content OK
 + no shared libs or need for -devel
 + runs and works nicely on my FC4 laptop with NetworkManager
     shut off (which is currently the default for NM)

nits:
 - please include the file "debian/copyright" in %doc
 - BuildRoot should be:
     %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 - please add /var/lib/wifiroamd to the list of owned dirs
 - I think the scriptlets should have if-s around them such as:

     %post
     if [ $1 -eq 1 ]; then
          chkconfig --add wifiroamd
     fi

     %preun
     if [ $1 -eq 0 ]; then
          chkconfig --del wifiroamd
     fi

   but please correct me if thats wrong!


Also, I'm wondering if there will or could be some conflicts with 
NetworkManager and, if so, how they should be handled.  Currently, NM is 
off by default and so is wifiroamd so they can only (potentially ??) 
conflict if a user chooses to turn on both simultaneously.  And even with 
both on, I'm not certain what problems, if any, would be observed.  Perhaps 
someone who knows a bit more about NetworkManager can step forward and say 
something here?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.