[Bug 185215] Review Request: adime - Allegro Dialogs Made Easy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: adime - Allegro Dialogs Made Easy


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185215





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-03-12 03:50 EST -------
Many thanks, and sorry I only ran rpmlint on the mainpackage (x86_64).


NONBLOCKING
===========
* License is actually the zlib license, which is very similar to BSD.
  However, since the zlib package itself claims a BSD license (rpm -qi zlib),
  this is not a blocker.

I actually had "zlib License" as License tag first, which is for example what
mandriva uses and rpmlint upstream accepts. Our rpmlint package however
overrides the list of valid licenses used by upstream and does not include zlib
hence the change to BSD, which is indeed what zlib uses too. So I can either
file an RFE against rpmlint to add "zlib License" or leave it as is, waht do you
think?


MUSTFIX
=======
* "make docs" generates warnings and fails to build the html/rtf documentation
  because the $srcdir/docs/html and $srcdir/docs/rtf directories are missing.
  I suggest adding the following to %prep to suppress these warnings:
    mkdir docs/html
    mkdir docs/rtf
  ...and including docs/html and docs/rtf in %doc

Done.


* BuildRequires: texinfo is needed to pull in 'makeinfo' to build the
  info files.  mock builds fail without this.

Done.


* rpmlint complains on i386 packages:
  E: adime shlib-with-non-pic-code /usr/lib/libadime.so.0
Ah an actual problem found by rpmlint how nice (sorry bit sarcastic, see below),
I fixed this by not using allegro-config --libs as that drags in
-lalleg_unshareable, which is non-PIC and thus should only be in the application
and not in a .so file. This means all applications which use us must be linked
with -Wl,--export-dynamic -lalleg_unsharable (or `allegro-config --libs`)


  W: adime-debuginfo objdump-failed objdump:
/tmp/adime-debuginfo-2.2.1-1.fc4.i386.rpm.30986/usr/lib/debug/usr/lib/libadime.so.0.debug:
Invalid operation

rpmlint bug, see bug 185227



  ...and on x86_64 packages:
  W: adime-debuginfo objdump-failed
Same rpmlint bug 185227


  E: adime-devel only-non-binary-in-usr-lib
And another rpmlint bug, what fun see bug 185228


New attemp (get the src.rpm, the patches changed too) at:
Spec Name or Url: http://home.zonnet.nl/jwrdegoede/adime.spec
SRPM Name or Url: http://home.zonnet.nl/jwrdegoede/adime-2.2.1-2.src.rpm


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.