[Bug 180015] Review Request: OTRS - Open Ticket Request System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: OTRS - Open Ticket Request System


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=180015





------- Additional Comments From mitr at redhat.com  2006-03-13 17:47 EST -------
* cpan-lib is currently a big problem because the package
  Provides: perl(the_modules), so it could get pulled in by yum instead of the
  perl module packages; yum would actually prefer otrs to the perl-whatever
  packages because "otrs" is a shorter name.

  otrs should have all perl(*) provides filtered out, including the internal
  Kernel::* modules.

  Removing cpan-lib completely won't work because Date-Pcalc and SOAP-Lite
  are not currently packaged in Fedora, and HTML::Safe is not even on CPAN.
  But after removing the other parts of cpan-lib and installing the
  corresponding Fedora packages otrs seems to work correctly.

  I was afraid it would be more packages, I think blocking otrs until 2 Perl
  modules are packaged is acceptable.  I'll help packaging them if necessary.

* I don't think the rpmlint warnings are a problem.
* I have tried installing Calendar-1.4.3 in the package manager, it failed
  because /var/www/otrs/var/httpd/htdocs/images/Standard isn't writable
  by apache.
* I see the "Useless use of AllowOverride:" warning on rawhide.
  http://httpd.apache.org/docs/2.2/mod/core.html#allowoverride says that
  AllowOverride is valid only in <Directory>.  Because a later
  <Directory .../cgi-bin> contains "AllowOverride None", it should be safe to
  just drop it from the <Location /otrs> section.

Other stuff:
* %pre assumes the apache group exists, so there should be Requires(pre): httpd.

Suggestions:
* Consider defining and using %{otrsdir} instead of repeating
  %{_localstatedir}/www/%{name} all over the spec file
* Consider using patches for the more modified files (redhat-rcorts*,
  apache2-httpd-new.include.conf), patches are more readable than a sequence of
  sed statements.
  The s|/opt/|...|g is OTOH probably better than a large patch.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.