[Bug 181369] Review Request: libedit - The NetBSD Editline library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libedit - The NetBSD Editline library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181369


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |jpmahowald at gmail.com




------- Additional Comments From jpmahowald at gmail.com  2006-03-13 18:38 EST -------
Naming Guidlines say post release snapshots are release.alpha. In your case,
Release would be 1.%{snap}cvs%{?dist}

rpmlint and the qa script  found these:

Needs work:
* The package should contain the text of the license
  (wiki: PackageReviewGuidelines)
* The package contains libtool archive files (*.la)
  (wiki: PackagingGuidelines#StaticLibraries)

W: libedit non-standard-group System/Libraries
W: libedit-devel non-standard-group Development/C
The group specified in your spec file is not valid.

The closest match in rpm's GROUPS file is System Environment/Libraries for both.

W: libedit incoherent-version-in-changelog 2.9-20060103cvs 2.9-20060103cvs.1.fc5
Your last entry in %changelog contains a version that is not coherent with
the current version of your package.

E: libedit library-without-ldconfig-postin /usr/lib/libedit.so.0.0.17
E: libedit library-without-ldconfig-postun /usr/lib/libedit.so.0.0.17
This package contains a library and provides no %post or %postun scriptlet
containing
a call to ldconfig.

W: libedit-debuginfo objdump-failed
Executing objdump on this file failed, all checks could not be run.

Not sure about this one. The debuginfo package seems to have been made correctly.





-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.