[Bug 169731] Review Request: ecl - Embeddable Common-Lisp

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ecl - Embeddable Common-Lisp


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=169731


jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778                      |163779
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2006-03-13 19:52 EST -------
You will likely want to make a note of the lack of a devel package in the spec.

* perl is not needed as a BuildRequires


Good:
- rpmlint checks return:
* some devel-file-in-non-devel-package, ignoring
* dangling symlinks from the debuginfo package back to the build dir, harmless
W: ecl-debuginfo objdump-failed, not serious

- package meets naming guidelines
- package meets packaging guidelines, exception for no devel package
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.