[Bug 185212] Review Request: freedoom - open source doom game files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: freedoom - open source doom game files


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185212


j.w.r.degoede at hhs.nl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |j.w.r.degoede at hhs.nl
                 CC|j.w.r.degoede at hhs.nl        |
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From j.w.r.degoede at hhs.nl  2006-03-14 03:34 EST -------
MUST
====
* Source tarball matches upstream
* Package (and .spec) named properly
* License file included
* Spec file readable, in Am. English
* Builds on FC-5 x86_64
* No locale files
* No excessive BR: or Requires:
* Not relocatable
* buildroot cleaned up in %install and %clean
* No duplicate files
* permissions ok
* Macro usage consistent
* Contains permissable content
* Desktop file included and properly installed

MUST FIX
========
License must be BSD not Distributable

SHOULD FIX
==========
* Use %{version} in Source0
* Remove:
# This package should Provide <enginename>-data for each doom engine
# that it is known to work with.
Concedering the procedure for doom wads we agreed on this is no longer true.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.