[Bug 185531] Review Request: fcron, a task scheduler
bugzilla at redhat.com
bugzilla at redhat.com
Wed Mar 15 16:17:46 UTC 2006
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: fcron, a task scheduler
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185531
pertusus at free.fr changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pertusus at free.fr
------- Additional Comments From pertusus at free.fr 2006-03-15 11:17 EST -------
First remark on the %pre script: I don't think the code that checks for an older
version and fixup things should be in the fedora spec. It adds a lot of unneeded
complexity without being able to catch all the possibilities. Moreover it uses
/tmp in an insecure way opening the possibility of a symlink attack.
I think it would be better to have a quick explanation of what should be done in
case there is an old fcron, at the end of the description.
A nitpick: I think that it is better not to add the package name in the summary,
it will always be added by the utilities that use the summary.
An advice: maybe it isn't sendmail which is required, but smtpdaemon.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
More information about the fedora-extras-list
mailing list