[Bug 183089] Review Request: ularn - a text-based roguelike game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ularn - a text-based roguelike game


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183089





------- Additional Comments From j.w.r.degoede at hhs.nl  2006-03-16 06:53 EST -------
Looking at the specfile some more comments:
-the config.sh stuff is messy, very messy. But if it works it works.
-why games games as default group/owner. This should be root root
-why games games for the binary, this should be root games. This way if someone
manages to get games uid rights he still can't modify (trojan) the binary
-why the fortune help and maps in /var/games can these be modified?
-why 775 for the dir can't you precreate the highscore file and make it 664 and
leave the directory as default (755). Or even better move maps help and fortunes
to /use/share and put the highscore file directly /var/games (with a name
indicating its owner package like ularn-highscores.bin)

And judging from the ularn-build.patch will all the varg stuff its a security
nigthmare, it doesnot do any networking does it? Otherwise it will first need a
full audit.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.