[Bug 182306] Review Request: dogtail - GUI test tool and automation framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: dogtail - GUI test tool and automation framework


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=182306


toshio at tiki-lounge.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |toshio at tiki-lounge.com
OtherBugsDependingO|163776, 177841              |163778
              nThis|                            |




------- Additional Comments From toshio at tiki-lounge.com  2006-03-20 01:16 EST -------
Mustfix:
* URL was fine last time.  Source0 was the field that needed to be changed.  So
  they should look like this:
  URL: http://people.redhat.com/zcerza/dogtail/
  Source0:
http://people.redhat.com/zcerza/dogtail/releases/%{name}-%{version}.tar.gz
* desktop file: I'm sorry.  I think my instructions were ambiguous on this.
  The desktop file needs to be installed via desktop-file-install in order
  to have vendor: fedora and category: X-Fedora added.  To do this, you can
  do this::
    BuildRequires: desktop-file-utils
    [...]
    %install
    desktop-file-install $RPM_BUILD_ROOT/%{_datadir}/applications/sniff.desktop
      --vendor=fedora \
      --dir=$RPM_BUILD_ROOT/%{_datadir}/applications \
      --add-category X-Fedora \
      --delete-original

  I don't think this program needs to have update-desktop-database run on
  install and uninstall (it's not adding a MimeType key).  If that was just
  added as part of the confusion, then this can all be removed::
    Requires(post): desktop-file-utils
    Requires(postun): desktop-file-utils
    [...]
    [In %post and in %postun]
    update-desktop-database &> /dev/null || :

Fixed:
* rpmlint warnings taken care of.
* Source matches the one upstream version.
* Problems in the source tarball have ben resolved.
* Now Buildrequires python.
* at-api-devel is no longer BuildRequired.
* examples are no longer executable.
* __os_install_post removed.
* Macros are used for directory names.
* System directories are not owned.
* gtk-update-icon-cache is properly invoked.
* Cosmetic items have been cleaned up as well.

Good:
* Still builds in mock on FC4 x86_64.
* Installs and runs fine on FC4 x86_64.

Fix the two problems, bump the release, update the srpm, and I'll approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.