Is this acceptable as a patch?

Paul Howarth paul at city-fan.org
Mon Mar 20 07:55:18 UTC 2006


On Sun, 2006-03-19 at 23:45 +0000, Paul wrote:
> Hi,
> 
> I'm currently working on getting z88dk to be architecture neutral, but
> have found a problem in the wholesale build process which I have a
> workaround for in the spec file.
> 
> However, I've found that if I alter the build.sh file to include the
> lines
> 
> PATH=`pwd`/bin:$PATH
> export PATH
> 
> the workaround can be avoided.
> 
> If I was to include that in a large patch, would it cause any sort of
> problems to the buildsys. I am always wary of altering environment
> variables, so would like some guidance on this.

I don't see a problem with that, particularly if you know that `pwd` is
always somewhere sane when build.sh is invoked.

Paul.




More information about the fedora-extras-list mailing list