[Bug 174883] Review Request: distcc -- A free distributed C/C++ compiler system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: distcc -- A free distributed C/C++ compiler system


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174883





------- Additional Comments From ch.nolte at fh-wolfenbuettel.de  2006-03-23 05:46 EST -------
The rpm's build fine under fc5. I have installed and tested the following
rpm's:

distcc-server-ssh-2.18.3-1.3
distcc-gnome-2.18.3-1.3
distcc-server-lsb-2.18.3-1.3
distcc-server-2.18.3-1.3

> there ARE rules to register/unregister the service

Sorry, I overlooked that. The file distccd.lsb you install as 
$RPM_BUILD_ROOT%_initrddir/distccd contains the following lines:

  ...
  f=/etc/sysconfig/distccd

  DISTCC_OPTS=
  DISTCC_ALLOW=127.0.0.1/32
  DISTCC_PIDFILE=/var/run/distccd/distccd.pid
  DISTCC_NICENESS=5
  DISTCC_USER=distcc
  test ! -r "$f" || . "$f"
  ...

But the file /etc/sysconfig/distccd is missing in your installation. I would
furthermore suggest not to test for readability (-r) but for existance (-a)of the 
sysconf-file.

rpmlint shows the following problems:

W: distcc-server-ssh no-documentation
W: distcc-gnome no-documentation
W: distcc-server-lsb conffile-without-noreplace-flag /etc/rc.d/init.d/distccd
W: distcc-server-lsb no-documentation
E: distcc-server-lsb executable-marked-as-config-file /etc/rc.d/init.d/distccd

  Ignoreable

E: distcc-server-lsb non-standard-gid /var/run/distccd distcc
E: distcc-server-lsb non-standard-dir-perm /var/run/distccd 0775

  That should be fixed, I guess.

E: distcc-server-lsb postin-without-chkconfig /etc/rc.d/init.d/distccd
E: distcc-server-lsb preun-without-chkconfig /etc/rc.d/init.d/distccd

  Ignoreable

W: distcc-server-lsb incoherent-init-script-name distccd
W: distcc-server conffile-without-noreplace-flag /var/log/distccd.log
E: distcc-server incoherent-logrotate-file /etc/logrotate.d/distccd
E: distcc-server non-standard-gid /var/log/distccd.log distcc
E: distcc-server non-root-group-log-file /var/log/distccd.log distcc

  This should be fixed, too.

W: distcc-server dangerous-command-in-%post chown

  Ignoreable

The initng-packages should be checked by someone else, because I have no time
for that.

Best regards
Christian

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.