[Bug 186566] Review Request: bsdiff - binary diff/patch utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: bsdiff - binary diff/patch utility


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186566





------- Additional Comments From jnovy at redhat.com  2006-03-30 11:55 EST -------
(In reply to comment #5)
> Well, trying to rebuild was yet another story :-)
> - Why force CC=gcc? It's the default with GNU make, isn't it?
It doesn't seem so. The default is CC=cc, which is actually a symlink to gcc, so
I just wanted to be sure gcc is called. I've got no problem to get rid of the
CC=gcc, so I removed it.

> - You patch the makefile in the install section, but don't use "make install"...
Note that the compiling process then fails when the .ifndef/.endif lines are
present within the Makefile with:

Makefile:13: *** missing separator.  Stop.
error: Bad exit status from /var/tmp/rpm-tmp.55595 (%build)

no matter whether the install or an other target is called. So the patch makes
the minimal changes to the Makefile so that it lets you compile it.

I'm more like minimalist so instead of adding huge patches to upstream makefiles
(actually rewriting them in your case) ;-), I'd apply only a minimal change to
the upstream one or make compilation manually in spec since the build process
here is trivial with no dependencies.

> you should document that (with a quick comment), since it's to fix the
> Makefile's validity!
???

> - CFLAGS wasn't set to use the optflags.
Yes, I missed this one. Added.

> - bzip2-devel build requirement was missing
Added.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.