[Bug 186993] Review Request: shippy - Space invaders / Galaxians like game with powerups

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: shippy - Space invaders / Galaxians like game with powerups


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=186993





------- Additional Comments From wart at kobold.org  2006-03-30 23:42 EST -------
I haven't seen any comments from tkmame lately, so here's a full review. 
tkmame:  please assign this to yourself if you would still like to give the
final approval.

MUST
====
rpmlint warnings:
W: shippy no-documentation
W: shippy-allegro no-documentation

Perhaps put at least the license file in each of these?  The rest of the
docs are in shippy-common, which is fine.

E: shippy non-standard-executable-perm /usr/bin/shippy-sdl 02755
E: shippy-allegro non-standard-executable-perm /usr/bin/shippy-allegro 02755

This is allowed per the Games SIG guidelines for shared scoreboard files.

E: shippy-common score-file-must-not-be-conffile /var/lib/games/shippy.hs

This will go away if you move it to /var/games per the FHS.

E: shippy-common zero-length /var/lib/games/shippy.hs

Empty initial scoreboard file.  This is fine.

* Package and spec named appropriately
* License (GPL) ok, license file included
* Spec file legible, in Am. English
* Source matches upstream
  06df2ae060fe4a076d7fa17a57205348  shipv1.3.3.7UNIX.zip
* compiles and builds on FC5 i386
* No excessive or offensive BR:
* No locales
* No shared libraries
* Not relocatable
* Owns directories that it creates (/usr/share/shippy)
* Permissions look ok.  setgid binary acceptable (see rpmlint warnings above)
* %install and %clean both clean $RPM_BUILD_ROOT
* %doc does not affect runtime
* Contains code and permissible content
* No -devel package
* .desktop file included and installed properly
* Runs without crashing

RECOMMENDED
===========
* Compiler warning:

shipall.c: In function 'SYSTEM_INIT':
shipall.c:264: warning: 'set_window_close_hook' is deprecated (declared at
/usr/include/allegro/alcompat.h:198)

This is probably safe for now, but you might want to consider not using the
deprecated function to avoid problems with future versions of allegro that
might remove it.

* Move the high score file from /var/lib/games to /var/games per FHS.  This will
also clean up one of the rpmlint warnings.

I don't consider either of the RECOMMENDED items blockers, but it would be nice
if Christopher could verify the joystick patch (no game port on my desktop,
unfortunately).

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.