[Bug 187430] Review Request: elektra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: elektra


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=187430





------- Additional Comments From joost at cnoc.nl  2006-03-31 14:51 EST -------
It doesn't build for me. I removed the debug-package comment, and fixed a type
on a date in the changelog.

But with the changelog, I meant a changelog for the package. So for now, only a
'Initial build' would be enough, something like this:
----------
* Fri Mar 31 2006 Avi Alkalay <avi at unix.sh> 0.6.0-0.1
- Initial build.
----------

further, what is this part for?
----------
# A buggy version of rpmbuild
%define _sysconfdir /etc
----------

In the buildrequires section you have db4-devel. Are you sure that the berkeley
sub-package doesn't need db4 to work? And GConf2 and libxml?

And the filename in the buildrequires, where is that good for?

Further, you're using $RPM_BUILD_ROOT, please change those in %{buildroot}

And you must uncomment the rm -rf ... from the %clean section, iirc.

and I'm not sure, but I thought that calling /sbin/ldconfig wasn't necessary.

Please review your spec file once more yourself, and try to build it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.