xview anyone ?

[Hans de Goede]

Christian Iseli wrote:
> On Wed, 01 Nov 2006 11:40:18 +0100, Hans de Goede wrote:
>> 1) Have you checked Debian's packages of this (if they have any) usually with hard to package software
>>    its a good idea to start with all Debian's patches (or atleast thosw which seem to make sense) that
>>    might fix this.
> 
> Yup, Pat basically used all the Debian stuff.
> 
>> 2) If you can give me a shortlist of instructions howto reproduce this then I can take a look at my 64
>>    bit machine at home (work doesn't have any 64 bit machines yet). As time permits of course.
> 
> Sure:
>  - grab ftp://ftp.licr.org/pub/xview-3.2-0.1.p4.src.rpm
>  - mock xview-3.2-0.1.p4.src.rpm on your 64-bit machine (for FC-[567])
>  - install xview, xview-clients, and xview-debuginfo
>  - launch "clock"
>  - watch it loop (it will not display anything, and use 100% CPU)
>  - attach a gdb to the process
> 
> Cheers,
> 					C


Well,

I've spend some hours taking a look and I've come to the same conclusion
as the Debian maintainer, this is very hard to fix for 64 bit. More then
that fixing probably will also include fixing / changing all xview using
clients!

Luckily all 64 bit platforms we support also have a 32 bit compatibility
option, so I think we should just not build xview (and apps using it)
for x86_64 / ppc64. It would be a good idea IMHO in cases like this to
add xview + deps + packages using it to a list of packages to copy over
to the x86_64 repo from the i386 repo, so that it will be readily
available for those who want it.

My taking a look started with suse since they had x86_64 packages of
xview in their repo, but appearantly these have had the famous suse QA
done do them (iow none). I did find some other interesting patches in
there, which I have bundled in a smaller one with possible real fixes
and a larger one which fixes a load of warnings (but no where near all
warnings). I also have a patch which fixes some 64 bit related warnings
by adding the necessary prototypes, which isn't enough to get this
running but IMHO still should be applied / send upstream (Debian claims
to be upstream these days) as it is an improvement.

I wanted to attach these patches to the review request but I can't find
it. Let me know where you want them send.

Regards,

Hans