rpms/geomview/devel geomview.spec,1.28,1.29

[Rex Dieter]

Ville Skyttä wrote:

> On Thu, 2006-10-26 at 12:34 -0700, Rex Dieter wrote:
> 
>> Modified Files:
>> geomview.spec
>> Log Message:
>> * Thu Oct 26 2006 Rex Dieter <rexdieter[AT]users.sf.net> 1.8.2-0.23.rc9
>> - fixup desktop-file-install usage
> [...]
>>  # .desktop entry
>> -mkdir -p $RPM_BUILD_ROOT%{_datadir}/applications
>> -desktop-file-install --vendor fedora \
>> +desktop-file-install --vendor="" \
>>    --dir $RPM_BUILD_ROOT%{_datadir}/applications \
>> -  --add-category X-Fedora \
>>    %{SOURCE1}
> 
> Isn't the above --vendor change directly against
> http://fedoraproject.org/wiki/PackagingDrafts/DesktopFiles [0]?  It'd
> cause the desktop file to be renamed between package revisions and thus
> breakage.
> 
> [0] "It is important that vendor_id stay constant for the life of a
> package."

Crap, violated my own packaging proposal.  I snarfed out both X-Fedora and
fedora by accident.

-- Rex