FE CVS: missing %dist %fedora?

[Ralf Corsepius]

On Tue, 2007-02-13 at 10:17 -0600, Jeffrey C. Ollie wrote:
> On Tue, 2007-02-13 at 16:36 +0100, Ralf Corsepius wrote:
> > On Tue, 2007-02-13 at 15:10 +0100, Ralf Corsepius wrote:
> > > Hi,
> > > 
> > > Seems to me as if building rpms in checked out copies of FE-CVS now
> > > seems broken:
> > > 
> > > After a "cvs up"
> > > make <arch>
> > > started to produce rpms without %dist and breaks building rpm-specs
> > > which apply %fedora.
> > > 
> > > Is this just me (and having screwed up locally)?
> > 
> > No, it's not just me, even a fresh anonymous checkout exposes this
> > issue.
> > 
> > # cvs -d :pserver:anonymous at cvs.fedora.redhat.com:/cvs/extras co Inventor
> > # cd Inventor/devel
> > # make i386
> > <boom>
> 
> AFAIK, "make i386" has never defined %dist and %fedora, because "make
> i386" is just running plain ol' rpmbuild with a few macros on the
> command line to get everything in the right directory.
You could be right ... the last change to Makefile.common is 1/2 year
old ;)

Except for very few packages (Inventor is one them) I don't actively use
%fedora and %dist inside of my specs, and am normally using mock for
building. So this might have escaped me :-o

>   %dist and %
> fedora are only defined in the build environment set up by mock.
"make srpm" supports them ;)

Ralf