rpms/ladspa-swh-plugins/FC-6 ladspa-swh-plugins.spec,1.1,1.2

[Gianluca Sforna]

On 1/23/07, Michael Schwendt <bugs.michael at gmx.net> wrote:
> On Sun, 7 Jan 2007 12:54:50 +0100, Michael Schwendt wrote:
>
> > On Sun, 7 Jan 2007 01:23:48 -0500, Anthony Green (green) wrote:
> >
> > > Author: green
> > >
> > > Update of /cvs/extras/rpms/ladspa-swh-plugins/FC-6
> > >
> > > Modified Files:
> > >     ladspa-swh-plugins.spec
> > > Log Message:
> > > Add SELinux support.
> >
> > > +%post
> > > +# Set SELinux file context in the policy
> > > +semanage fcontext -f -- -a -t textrel_shlib_t '%{_libdir}/ladspa/sc4m_1916.so' 2>/dev/null || :
> > > +# Actually change the context
> > > +chcon -R -t textrel_shlib_t %{_libdir}/ladspa/sc4m_1916.so || :
> > > +
> > > +%postun
> > > +# SELinux support
> > > +if [ $1 -eq 0 ]; then  # final removal
> > > +  semanage fcontext -f -- -d -t textrel_shlib_t %{_libdir}/ladspa/sc4m_1916.so || :
> > > +fi
> > > +
> >
> > Shouldn't this be built with -fPIC/-fpic instead of changing the SELinux
> > context?
>
> +1/-1 from anyone else, please.

+1
IMO messing around with SELinux contexts in the scriptlets is not a
viable/dependable option.
First try to fix the library, then if it really need it, file a BZ
request for inclusion in the selinux-policy package