[Bug 468823] Review Request: hanazono-fonts - Japanese Mincho-typeface TrueType font

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468823


Akira TAGOH <tagoh at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(tagoh at redhat.com) |




--- Comment #5 from Akira TAGOH <tagoh at redhat.com>  2008-11-10 00:12:08 EDT ---
Thank you for taking a review for this package.

(In reply to comment #3)
> 1. you're packaging a font with a new license. While at first view it seems ok,
> you still need spot to approve it and put it on
> http://fedoraproject.org/wiki/Legal_considerations_for_fonts

I've already asked on fedora-legal-list, and just followed him to describe
License tag -
https://www.redhat.com/archives/fedora-legal-list/2008-October/msg00022.html

> 2. please follow the font packaging process outlined on 
> http://fedoraproject.org/wiki/Font_package_lifecycle
> and in particular create a wiki page that describes your font and can be
> referenced in release notes

Just created: https://fedoraproject.org/wiki/Hanazono_font

> 3. your fontconfig priority (59) is a little low, our guidelines states CJK
> fonts should be in the 65-69 range
> http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Simple_priority_lists
> 
> 4. your fontconfig rule is a bit more convoluted than what we usually do. It
> probably works but please get Behdad to review it (and ok it there).

I'd like to push this font prior to sazanami-mincho.ttf which we defaults for
Serif for Japanese, because the quality is better than it. I'm not sure what's
the right thing to do that for fontconfig config. that would be appreciated if
someone could helps me.

> 5. please also alias the font the other way, so fontconfig knows it should use
> serif fonts to complete HanaMin
> http://fedoraproject.org/wiki/Fontconfig_packaging_tips#Generic_names

Fixed in the updated package.

> 6. please send your fontconfig file to hanazano upstream so it's included in
> their next release once you're happy with it

Sure.

> 7. you can drop the -f argument to fc-cache for releases ≥ Fedora 9

Can you update the template page as well to see what's the expected thing
hereafter?

> 8. please use the defattr suggested by guidelines %defattr(644,root,root,755)

Sorry, missed one. fixed.

> 9. it's a little easier to review a package when the fields are in the same
> order as in rpmdevtool's  spectemplate-fonts.spec (cosmetic, you can ignore it,
> just take it into account for your next font package)

Oh, wasn't aware of that. improved a bit in:

Spec URL: http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts.spec
SRPM URL:
http://tagoh.fedorapeople.org/hanazono-fonts/hanazono-fonts-20081012-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.