[Bug 526633] Review Request: gargi-fonts - A Devanagari font
bugzilla at redhat.com
bugzilla at redhat.com
Mon Oct 5 13:11:42 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=526633
Ankur Sinha <sanjay.ankur at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|needinfo?(sanjay.ankur at gmai |
|l.com) |
--- Comment #7 from Ankur Sinha <sanjay.ankur at gmail.com> 2009-10-05 09:11:41 EDT ---
(In reply to comment #3)
> Anyway, thanks a lot for adding a new font package in the review pipe
>
> Appart from the CSS classification I can't really help you with, here is some
> review:
>
> 1. non LGC font ⇒ please use a priority ≥ 65 as per fontconfig-priorities.txt
>
I'll check up the prio for the lohit font and fix this..
> 3. Licensing should be GPLv2+
Fixed. Will upload a new build in a day max.
>
> 4. (non blocking) please ask upstream to add the standard FSF GPL font
> exception to their licensing
Contacted upstream, no response yet :(
>
> 5. (non blocking) description could use some meat
I copied whatever I got from the font homepage. There's no readme etc to get
more from.
> Anyway, this package is mostly fine, except for the classification problem.
>
> NEEDINFO till this is resolved
(In reply to comment #6)
> Ankur, please use Sans as classification and I'll approve the package (if you
> fixed the other bits. Also, please make sure your fontconfig prio is > Lohit
> Devanagari so Lohit stays the default
Okay, ill fix up the fontconfig. I cant do much about some of the other bits
(stated above)
regards,
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-fonts-bugs-list
mailing list