[Bug 512079] Review Request: oflb-prociono-fonts - A serif font created by Barry Schwartz

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512079


Nicolas Mailhot <nicolas.mailhot at laposte.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |nicolas.mailhot at laposte.net
               Flag|                            |fedora-review?




--- Comment #3 from Nicolas Mailhot <nicolas.mailhot at laposte.net>  2009-09-14 16:37:13 EDT ---
Review:

1. please do not put changelog-like info in a package description (what's new
in the latest version). The description is supposed to be stable over time so
l10 does not struggle with it

2. attribution to Barry Shwartz is better done in the description than in the
summary

3. the rest of the spec mostly follows the standard template and thus is ok

4. the fontconfig rule is ok too, and the prio seems sane

5. oflb-prociono-fonts.src: W: uncompressed-zip chemoelectric_-_Prociono.zip 
is not your problem, that just means upstream forgot to compress its zip, so it
wastes space

So the technical part of package is good, just clear your licensing doubts with
Spot and I'll approve it all

(sorry I was not available in august to look at this fine package)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.