macrofied kernel.spec

[Jarod Wilson]

>> Just realized it looks like you also snuck in a kernel-PAE-debug build=

>> variant... ;) Damn, it'd be nice if koji could spread kernel variant
>> builds of the same arch across multiple builders...
>=20
> I didn't add it, it was already there.  I just made it uniform with the=

> others.  Maybe the hand-editted duplication had left it not working?  O=
r
> not entirely removed when it was intended to be?

Huh. So it is... Hrm. Something is apparently causing it to not get
built right now though:

http://koji.fedoraproject.org/packages/kernel/2.6.23/0.61.rc1.git9.fc8/i6=
86/

(the lack of it showing up there was what made me think you'd added
that, serves me right for not looking at the current spec)

I'll poke around and see if I can figure out why it isn't getting built.
Not obvious at first glance...

>> Some of the documentation about what the -s and -r flags represent in
>> the %kernel_variant_post would probably be worth adding though (just
>> says [-s <s> -r <r>] right now in the comment header, and my best gues=
s
>> is s=3Dstring, r=3Dreplacement).
>=20
> Yeah, it forms a sed s command.

Yep, got that part, just meant that header explanation could have made
it clearer what those two flags were for.

>> Only other thing I'm seeing right now, though its probably been this w=
ay
>> forever, is that we're a bit inconsistent about whether we use %{name}=

>> or just 'kernel' in %package and %description.
>=20
> That matters when doing the variant-source packages like kernel-vanilla=
,
> which I haven't tested lately.  For the "install the kernel-foo package=
"
> parts of %description, %{name}-foo might be better since it will make t=
he
> literal instructions match the intended reality for that case.
>=20
> For the provides/requires some are intended to be %{name} and some kern=
el.
> i.e., %{name}-debuginfo-common-%{_target_cpu}, but kernel-drm.

I volunteer to go through and try to make everything consistent once the
dust settles a bit.

--=20
Jarod Wilson
jwilson at redhat.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-kernel-list/attachments/20070802/e66cb7b8/attachment.sig>