typo in new spec file (F7)

[Ignacio Vazquez-Abrams]

On Sun, 2007-07-29 at 20:43 -0400, Jarod Wilson wrote:
> Tom "spot" Callaway wrote:
> > On Sat, 2007-07-28 at 16:23 -0400, Ignacio Vazquez-Abrams wrote:
> >> On Sat, 2007-07-28 at 16:02 -0400, Sam Folk-Williams wrote:
> >>> I noticed this in the kernel-2.6.22.1-33.fc7.src.rpm spec file as I was 
> >>> revising the kernel build docs:
> >>>
> >>> #% define buildid .local
> >>>
> >>> Just need to remove that space before 'define', otherwise we get the 
> >>> following after uncommenting.
> >>>
> >>> error: line 15: Unknown tag: % define buildid .local
> >> Better yet, double up the percent sign so that rpm doesn't try to
> >> interpret the %define macro.
> > 
> > My guess is that the space is there specifically to prevent rpm from
> > interpreting the %define macro (simply # commenting doesn't prevent it).
> 
> Yup. Originally, I think it was a # replacing a %, but at some point, 
> moved to "#% "... Same difference.
> 
> > %% is a cleaner way to do it, but some packagers may not realize it
> > disables the macro.
> 
> While %% may be a bit cleaner, a # in front of it makes more sense to 
> more people I think.

My point is that you need *both* since rpm will interpret the macro
regardless of whether or not it's commented out.

-- 
Ignacio Vazquez-Abrams <ivazqueznet at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-kernel-list/attachments/20070729/bdebbc32/attachment.sig>