RFC: Minor specfile rework for rawhide

Jarod Wilson jwilson at redhat.com
Tue Jan 22 04:20:17 UTC 2008


Christopher Brown wrote:
> On 21/01/2008, Adam Jackson <ajackson at redhat.com> wrote:
>> http://people.freedesktop.org/~ajax/kernel-autopatch.patch
>>
>> Based on something I did for the xserver specfile.  Essentially this
>> makes it so you only have to name the patches once, in the order you
>> want to apply them, which makes it both easier to work with and harder
>> to forget things.
>>
>> I've tried to make this as friendly and robust as possible, including
>> bailing out appropriately when faced with a bad patch, and explicitly
>> naming patches that fail to apply right at the end of build output.
>> Feedback would be appreciated, even if it's of the form "no, that's
>> gross."
> 
> Can't speak from an implementation point of view but you must be a
> mind-reader. Several people will appreciate the thought behind it,
> myself included. On #fedora-kernel recently:
> 
> <kylem> i really find it irritating that i need to edit Patchxx: *and*
> add an ApplyPatch.
> * kylem ponders converting the spec file to use quilt.
> <j-rod> fark
> <j-rod> not a fan of that either
> <jwb> why not j-rod ?
> <f13> I think he meant he's not a fan of editing twice.
> <f13> not that he wasn't a fan of quilt.
> <jwb> oh
> <kylem> i always forget to do one or the other :\

First glance says oh hell yeah, check it in.

-- 
Jarod Wilson
jwilson at redhat.com


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 251 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/fedora-kernel-list/attachments/20080121/69a4d0ce/attachment.sig>


More information about the Fedora-kernel-list mailing list