From jarod at redhat.com Tue Mar 3 21:07:38 2009 From: jarod at redhat.com (Jarod Wilson) Date: Tue, 3 Mar 2009 16:07:38 -0500 Subject: File conflicts between alsa-firmware and kernel-firmware In-Reply-To: <49A96ABD.4060608@timj.co.uk> References: <49A96ABD.4060608@timj.co.uk> Message-ID: <200903031607.39069.jarod@redhat.com> On Saturday 28 February 2009 11:47:57 Tim Jackson wrote: > I maintain alsa-firmware and the following bug regarding file conflicts > between recent versions of kernel-firmware and alsa-firmware got raised today: > > https://bugzilla.redhat.com/show_bug.cgi?id=487873 > > I'm not really familiar with the kernel package maintenance, nor who/what > governs what firmware goes into kernel-firmware (and indeed how that is > related to the upstream kernel). I had a cursory look at the kernel spec > in CVS but that didn't appear to have any relevant recent changes that > were obvious. > > I did a diff between the firmware in alsa-firmware and in > kernel-firmware-2.6.29-0.172.rc6.git4.fc11 and it's clear that although > there are some overlaps, much of the audio firmware in alsa-firmware isn't > in kernel-firmware. > > The current conflicting files are: > > ess/* > korg/* > sb16/* > yamaha/ds1_ctrl.fw > yamaha/ds1_dsp.fw > yamaha/ds1e_ctrl.fw > > Things that are in alsa-firmware but NOT in the above version of > kernel-firmware are: > > asihpi/* > digiface* > 3g* > ea/* > emu/* > mixart/* > multiface* > pcxhr/* > vx/* > yamaha/yss225_registers.bin > [usx2y, which does something funky so it's not in /lib/firmware] > > Either way, it looks like we need to work together on this. > > - I'm happy to just drop the conflicting files from alsa-firmware - is > that the right thing to do? I'd say yes. The versions shipped in the kernel are (supposed to be) known to work with the matching shipped kernel code. > - Are the above audio firmware files in kernel-firmware there to stay? They're put into kernel-firmware as part of the kernel's firmware "build" process, so as long as they're part of the kernel, yeah, they'll be there. > - Is there a long term goal to bring all the firmware from alsa-firmware > upstream into the kernel-firmware package? No clue... Would have to talk to some alsa folks. -- Jarod Wilson jarod at redhat.com From oliver at linux-kernel.at Wed Mar 4 07:59:37 2009 From: oliver at linux-kernel.at (Oliver Falk) Date: Wed, 04 Mar 2009 08:59:37 +0100 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <20090228193202.GC28503@bombadil.infradead.org> References: <20090226095127.51BEE2084D1@bastion.fedora.phx.redhat.com> <20090226174420.GO6690@bombadil.infradead.org> <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> Message-ID: <49AE34E9.3070901@linux-kernel.at> Hi! Changed the subject, as happens that I oversee the mails :-( And this subject is more descriptive, isn't it? Kyle McMartin wrote: [ ... ] > This all looks fine to me. May I interpret this as a *GO*? :-) > Sorry to have been so blunt, but I'm fairly > new to Fedora, so I didn't know you were actually working on stuff, and > not just someone asking for random commit access. Don't worry. I didn't get this wrong. I can understand you where worrying. If I'd be in your position, I would react differently. > I wouldn't worry too much about the linux-2.6- namespace for patches, > I'd prefer if they were just alpha-$patch.patch. davej, thoughts? Whatever you prefer. Let me know, so I start working on this today... Best, Oliver From oliver at linux-kernel.at Wed Mar 4 07:59:37 2009 From: oliver at linux-kernel.at (Oliver Falk) Date: Wed, 04 Mar 2009 08:59:37 +0100 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <20090228193202.GC28503@bombadil.infradead.org> References: <20090226095127.51BEE2084D1@bastion.fedora.phx.redhat.com> <20090226174420.GO6690@bombadil.infradead.org> <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> Message-ID: <49AE34E9.3070901@linux-kernel.at> Hi! Changed the subject, as happens that I oversee the mails :-( And this subject is more descriptive, isn't it? Kyle McMartin wrote: [ ... ] > This all looks fine to me. May I interpret this as a *GO*? :-) > Sorry to have been so blunt, but I'm fairly > new to Fedora, so I didn't know you were actually working on stuff, and > not just someone asking for random commit access. Don't worry. I didn't get this wrong. I can understand you where worrying. If I'd be in your position, I would react differently. > I wouldn't worry too much about the linux-2.6- namespace for patches, > I'd prefer if they were just alpha-$patch.patch. davej, thoughts? Whatever you prefer. Let me know, so I start working on this today... Best, Oliver From oliver at linux-kernel.at Thu Mar 5 09:56:18 2009 From: oliver at linux-kernel.at (Oliver Falk) Date: Thu, 05 Mar 2009 10:56:18 +0100 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <49AE34E9.3070901@linux-kernel.at> References: <20090226095127.51BEE2084D1@bastion.fedora.phx.redhat.com> <20090226174420.GO6690@bombadil.infradead.org> <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> <49AE34E9.3070901@linux-kernel.at> Message-ID: <49AFA1C2.8060807@linux-kernel.at> Oliver Falk wrote: > Hi! > > Changed the subject, as happens that I oversee the mails :-( > And this subject is more descriptive, isn't it? > > Kyle McMartin wrote: > [ ... ] >> This all looks fine to me. > > May I interpret this as a *GO*? :-) > > > Sorry to have been so blunt, but I'm fairly >> new to Fedora, so I didn't know you were actually working on stuff, and >> not just someone asking for random commit access. > > Don't worry. I didn't get this wrong. I can understand you where > worrying. If I'd be in your position, I would react differently. > >> I wouldn't worry too much about the linux-2.6- namespace for patches, >> I'd prefer if they were just alpha-$patch.patch. davej, thoughts? > > Whatever you prefer. > > Let me know, so I start working on this today... Ping? -of From bmaly at redhat.com Fri Mar 6 20:32:52 2009 From: bmaly at redhat.com (Brian Maly) Date: Fri, 06 Mar 2009 15:32:52 -0500 Subject: [PATCH] x86: fix DMI for EFI Message-ID: <49B18874.7080503@redhat.com> resolves BZ 488579 Impact: reactivate DMI quirks on EFI hardware DMI tables are loaded by EFI, so the dmi calls must happen after efi_init() and not before. Currently Apple hardware uses DMI to determine the framebuffer mappings for efifb. Without DMI working you also have no video on MacBook Pro. This patch resolves the DMI issue for EFI hardware (DMI is now properly detected at boot), and additionally efifb now loads on Apple hardware (i.e. video works). Upstream commit: http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commitdiff;h=ff0c0874905fb312ca1491bbdac2653b0b48c20b It would be helpful to have this patch included in Fedora before UEFI test day (April 9th, 2009), if possible, being that the largest percentage of UEFI hardware currently on the market is made by Apple. In that respect, this patch is somewhat important. Brian From bmaly at redhat.com Fri Mar 6 20:34:12 2009 From: bmaly at redhat.com (Brian Maly) Date: Fri, 06 Mar 2009 15:34:12 -0500 Subject: [PATCH] EFI: fix efi_ioremap Message-ID: <49B188C4.3020506@redhat.com> resolves BZ 466954 efi_ioremap is currently broken in fedora, so systems that have large efi runtime regions mapped into higher mem are not able to re-map, the result being the system fails to boot. The core issue is that any region > 400K cannot currently be remapped with efi_ioremap due to size limitations within the efi_ioremap code. So when an efi runtime region is larger than 400K and in higher mem, it is not remapped. Systems most affected by this issue tend to be made by Apple. This patch was tested on MacBook Pro (Santa Rosa) and resolves the issue. Upstream commit: http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commitdiff;h=dd39ecf522ba86c70809715af46e6557f6491131 It would be helpful to have this patch included in Fedora before UEFI test day (April 9th, 2009), if possible, being that the largest percentage of UEFI hardware currently on the market is made by Apple. In that respect, this patch is somewhat important. Brian ------------------------------------------------------------------------ From bmaly at redhat.com Fri Mar 6 20:38:26 2009 From: bmaly at redhat.com (Brian Maly) Date: Fri, 06 Mar 2009 15:38:26 -0500 Subject: [PATCH] EFI: fix efi_ioremap In-Reply-To: <49B188C4.3020506@redhat.com> References: <49B188C4.3020506@redhat.com> Message-ID: <49B189C2.6010302@redhat.com> I had attached the patch in my previous post but the patch seems to have been stripped off once it got posted to the list. I can forward a patch to whomever needs it if its undesirable to extract from the commit info. Just let me know what works best. Brian From bmaly at redhat.com Fri Mar 6 20:38:40 2009 From: bmaly at redhat.com (Brian Maly) Date: Fri, 06 Mar 2009 15:38:40 -0500 Subject: [PATCH] x86: fix DMI for EFI In-Reply-To: <49B18874.7080503@redhat.com> References: <49B18874.7080503@redhat.com> Message-ID: <49B189D0.1040105@redhat.com> I had attached the patch in my previous post but the patch seems to have been stripped off once it got posted to the list. I can forward a patch to whomever needs it if its undesirable to extract from the commit info. Just let me know what works best. Brian From jarod at redhat.com Mon Mar 9 14:23:23 2009 From: jarod at redhat.com (Jarod Wilson) Date: Mon, 9 Mar 2009 10:23:23 -0400 Subject: [PATCH] x86: fix DMI for EFI In-Reply-To: <49B189D0.1040105@redhat.com> References: <49B18874.7080503@redhat.com> <49B189D0.1040105@redhat.com> Message-ID: <200903091023.23648.jarod@redhat.com> On Friday 06 March 2009 15:38:40 Brian Maly wrote: > I had attached the patch in my previous post but the patch seems to have > been stripped off once it got posted to the list. > I can forward a patch to whomever needs it if its undesirable to extract > from the commit info. Just let me know what works best. It'll get picked up via an upstream rebase long before then. I saw it last night in rc7-git2, and that or later is bound to be pulled into rawhide long before April (its likely to get in today). -- Jarod Wilson jarod at redhat.com From oliver at linux-kernel.at Wed Mar 11 08:52:44 2009 From: oliver at linux-kernel.at (Oliver Falk) Date: Wed, 11 Mar 2009 09:52:44 +0100 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <49AE34E9.3070901@linux-kernel.at> References: <20090226095127.51BEE2084D1@bastion.fedora.phx.redhat.com> <20090226174420.GO6690@bombadil.infradead.org> <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> <49AE34E9.3070901@linux-kernel.at> Message-ID: <49B77BDC.9060707@linux-kernel.at> Oliver Falk wrote: > Hi! > > Changed the subject, as happens that I oversee the mails :-( > And this subject is more descriptive, isn't it? > > Kyle McMartin wrote: > [ ... ] >> This all looks fine to me. > > May I interpret this as a *GO*? :-) > > > Sorry to have been so blunt, but I'm fairly >> new to Fedora, so I didn't know you were actually working on stuff, and >> not just someone asking for random commit access. > > Don't worry. I didn't get this wrong. I can understand you where > worrying. If I'd be in your position, I would react differently. > >> I wouldn't worry too much about the linux-2.6- namespace for patches, >> I'd prefer if they were just alpha-$patch.patch. davej, thoughts? > > Whatever you prefer. > > Let me know, so I start working on this today... Did I miss the answer to my mail!? -of From davej at redhat.com Wed Mar 11 13:30:28 2009 From: davej at redhat.com (Dave Jones) Date: Wed, 11 Mar 2009 09:30:28 -0400 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <49B77BDC.9060707@linux-kernel.at> References: <20090226095127.51BEE2084D1@bastion.fedora.phx.redhat.com> <20090226174420.GO6690@bombadil.infradead.org> <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> <49AE34E9.3070901@linux-kernel.at> <49B77BDC.9060707@linux-kernel.at> Message-ID: <20090311133028.GA30421@redhat.com> On Wed, Mar 11, 2009 at 09:52:44AM +0100, Oliver Falk wrote: > Oliver Falk wrote: > > Hi! > > > > Changed the subject, as happens that I oversee the mails :-( > > And this subject is more descriptive, isn't it? > > > > Kyle McMartin wrote: > > [ ... ] > >> This all looks fine to me. > > > > May I interpret this as a *GO*? :-) > > > > > Sorry to have been so blunt, but I'm fairly > >> new to Fedora, so I didn't know you were actually working on stuff, and > >> not just someone asking for random commit access. > > > > Don't worry. I didn't get this wrong. I can understand you where > > worrying. If I'd be in your position, I would react differently. > > > >> I wouldn't worry too much about the linux-2.6- namespace for patches, > >> I'd prefer if they were just alpha-$patch.patch. davej, thoughts? > > > > Whatever you prefer. > > > > Let me know, so I start working on this today... > > Did I miss the answer to my mail!? Sorry, I was on vacation, and it fell off my radar when I got back. Looked ok to commit to me though iirc. I've no really preference on patch naming. If you want to do alpha-*, go ahead. but don't feel that you have to. Dave -- http://www.codemonkey.org.uk From oliver at linux-kernel.at Wed Mar 11 13:42:31 2009 From: oliver at linux-kernel.at (Oliver Falk) Date: Wed, 11 Mar 2009 14:42:31 +0100 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <20090311133028.GA30421@redhat.com> References: <20090226095127.51BEE2084D1@bastion.fedora.phx.redhat.com> <20090226174420.GO6690@bombadil.infradead.org> <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> <49AE34E9.3070901@linux-kernel.at> <49B77BDC.9060707@linux-kernel.at> <20090311133028.GA30421@redhat.com> Message-ID: <49B7BFC7.3010603@linux-kernel.at> Dave Jones wrote: > On Wed, Mar 11, 2009 at 09:52:44AM +0100, Oliver Falk wrote: > > Oliver Falk wrote: > > > Hi! > > > > > > Changed the subject, as happens that I oversee the mails :-( > > > And this subject is more descriptive, isn't it? > > > > > > Kyle McMartin wrote: > > > [ ... ] > > >> This all looks fine to me. > > > > > > May I interpret this as a *GO*? :-) > > > > > > > Sorry to have been so blunt, but I'm fairly > > >> new to Fedora, so I didn't know you were actually working on stuff, and > > >> not just someone asking for random commit access. > > > > > > Don't worry. I didn't get this wrong. I can understand you where > > > worrying. If I'd be in your position, I would react differently. > > > > > >> I wouldn't worry too much about the linux-2.6- namespace for patches, > > >> I'd prefer if they were just alpha-$patch.patch. davej, thoughts? > > > > > > Whatever you prefer. > > > > > > Let me know, so I start working on this today... > > > > Did I miss the answer to my mail!? > > Sorry, I was on vacation, and it fell off my radar when I got back. > Looked ok to commit to me though iirc. > > I've no really preference on patch naming. If you want to do alpha-*, go ahead. > but don't feel that you have to. OK. I'll commit the changes in a clean way, add CL, etc. We can still move the patches and use other names. Or any other change that might be necessary... Best, Oliver From tcallawa at redhat.com Wed Mar 11 14:27:51 2009 From: tcallawa at redhat.com (Tom "spot" Callaway) Date: Wed, 11 Mar 2009 10:27:51 -0400 Subject: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*) Message-ID: <49B7CA67.8030108@redhat.com> The radeon_buffer.c addition that gets pulled into the DRM driver as part of Kernel Mode Setting (even if you disable KMS for the Radeon driver) was assuming that it was safe to use symbols from the AGP code, but that isn't safe on platforms where __OS_HAS_AGP is 0. Such as sparc64. :) This patch gets the code building again. It probably should go into the actual kms patch, but if you would prefer this go as a separate patch, I can apply it. With this, we can get rawhide building for sparc64, so I'm eager to see it applied in one way or another. Signed-off-by: Tom "spot" Callaway -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: linux-2.6.29-kms-noagp.patch URL: From jwboyer at gmail.com Wed Mar 11 15:33:25 2009 From: jwboyer at gmail.com (Josh Boyer) Date: Wed, 11 Mar 2009 11:33:25 -0400 Subject: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*) In-Reply-To: <49B7CA67.8030108@redhat.com> References: <49B7CA67.8030108@redhat.com> Message-ID: <20090311153325.GA30822@yoda.jdub.homelinux.org> On Wed, Mar 11, 2009 at 10:27:51AM -0400, Tom spot Callaway wrote: >The radeon_buffer.c addition that gets pulled into the DRM driver as >part of Kernel Mode Setting (even if you disable KMS for the Radeon >driver) was assuming that it was safe to use symbols from the AGP code, >but that isn't safe on platforms where __OS_HAS_AGP is 0. Such as >sparc64. :) > >This patch gets the code building again. It probably should go into the >actual kms patch, but if you would prefer this go as a separate patch, I >can apply it. With this, we can get rawhide building for sparc64, so I'm >eager to see it applied in one way or another. > >Signed-off-by: Tom "spot" Callaway >diff -up linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c.BAD linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c >--- linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c.BAD 2009-03-11 09:11:01.000000000 -0500 >+++ linux-2.6.28.sparc64/drivers/gpu/drm/radeon/radeon_buffer.c 2009-03-11 09:11:27.000000000 -0500 >@@ -37,9 +37,11 @@ struct drm_ttm_backend *radeon_create_tt > { > drm_radeon_private_t *dev_priv = dev->dev_private; > >+#if __OS_HAS_AGP Not that this is your fault, but shouldn't this be something like __ARCH_HAS_AGP? josh From kyle at infradead.org Wed Mar 11 15:55:53 2009 From: kyle at infradead.org (Kyle McMartin) Date: Wed, 11 Mar 2009 11:55:53 -0400 Subject: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*) In-Reply-To: <20090311153325.GA30822@yoda.jdub.homelinux.org> References: <49B7CA67.8030108@redhat.com> <20090311153325.GA30822@yoda.jdub.homelinux.org> Message-ID: <20090311155553.GD5448@bombadil.infradead.org> On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote: > >+#if __OS_HAS_AGP > > Not that this is your fault, but shouldn't this be something > like __ARCH_HAS_AGP? > Keep in mind the DRM for better or for worse supposedly supports more OSes than just Linux. I suspect the 'ideal' fix for upstream is to stub out drm_agp_init_ttm on !CONFIG_AGP arches. regards, Kyle From tcallawa at redhat.com Wed Mar 11 16:16:36 2009 From: tcallawa at redhat.com (Tom "spot" Callaway) Date: Wed, 11 Mar 2009 12:16:36 -0400 Subject: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*) In-Reply-To: <20090311153325.GA30822@yoda.jdub.homelinux.org> References: <49B7CA67.8030108@redhat.com> <20090311153325.GA30822@yoda.jdub.homelinux.org> Message-ID: <49B7E3E4.2090908@redhat.com> On 03/11/2009 11:33 AM, Josh Boyer wrote: >> +#if __OS_HAS_AGP > > Not that this is your fault, but shouldn't this be something > like __ARCH_HAS_AGP? Maybe, but I'm not about to redefine existing kernel defines for the purposes of logic. ;) ~spot From jwboyer at gmail.com Wed Mar 11 16:39:06 2009 From: jwboyer at gmail.com (Josh Boyer) Date: Wed, 11 Mar 2009 12:39:06 -0400 Subject: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*) In-Reply-To: <20090311155553.GD5448@bombadil.infradead.org> References: <49B7CA67.8030108@redhat.com> <20090311153325.GA30822@yoda.jdub.homelinux.org> <20090311155553.GD5448@bombadil.infradead.org> Message-ID: <20090311163906.GB30822@yoda.jdub.homelinux.org> On Wed, Mar 11, 2009 at 11:55:53AM -0400, Kyle McMartin wrote: >On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote: >> >+#if __OS_HAS_AGP >> >> Not that this is your fault, but shouldn't this be something >> like __ARCH_HAS_AGP? >> > >Keep in mind the DRM for better or for worse supposedly supports more >OSes than just Linux. I had blissfully forgotten that. >I suspect the 'ideal' fix for upstream is to stub out drm_agp_init_ttm >on !CONFIG_AGP arches. Yeah, something like that. josh From airlied at redhat.com Wed Mar 11 20:44:40 2009 From: airlied at redhat.com (Dave Airlie) Date: Thu, 12 Mar 2009 06:44:40 +1000 Subject: [PATCH] Don't try to use agp symbols if we don't have AGP (*cough*sparc*cough*) In-Reply-To: <20090311155553.GD5448@bombadil.infradead.org> References: <49B7CA67.8030108@redhat.com> <20090311153325.GA30822@yoda.jdub.homelinux.org> <20090311155553.GD5448@bombadil.infradead.org> Message-ID: <1236804280.16920.4.camel@optimus> On Wed, 2009-03-11 at 11:55 -0400, Kyle McMartin wrote: > On Wed, Mar 11, 2009 at 11:33:25AM -0400, Josh Boyer wrote: > > >+#if __OS_HAS_AGP > > > > Not that this is your fault, but shouldn't this be something > > like __ARCH_HAS_AGP? > > > > Keep in mind the DRM for better or for worse supposedly supports more > OSes than just Linux. > > I suspect the 'ideal' fix for upstream is to stub out drm_agp_init_ttm > on !CONFIG_AGP arches. OS_HAS_AGP is just a wrapper around convoluted CONFIG_AGP, CONFIG_AGP_MODULE. Its perfectly acceptable to build a kernel with no AGP and DRM enabled on x86. Dave. > > regards, Kyle From oliver at linux-kernel.at Thu Mar 12 12:59:14 2009 From: oliver at linux-kernel.at (Oliver Falk) Date: Thu, 12 Mar 2009 13:59:14 +0100 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <49B7BFC7.3010603@linux-kernel.at> References: <20090226095127.51BEE2084D1@bastion.fedora.phx.redhat.com> <20090226174420.GO6690@bombadil.infradead.org> <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> <49AE34E9.3070901@linux-kernel.at> <49B77BDC.9060707@linux-kernel.at> <20090311133028.GA30421@redhat.com> <49B7BFC7.3010603@linux-kernel.at> Message-ID: <49B90722.4090901@linux-kernel.at> Oliver Falk wrote: > Dave Jones wrote: >> On Wed, Mar 11, 2009 at 09:52:44AM +0100, Oliver Falk wrote: >> > Oliver Falk wrote: >> > > Hi! >> > > > > Changed the subject, as happens that I oversee the mails :-( >> > > And this subject is more descriptive, isn't it? >> > > > > Kyle McMartin wrote: >> > > [ ... ] >> > >> This all looks fine to me. >> > > > > May I interpret this as a *GO*? :-) >> > > > > > Sorry to have been so blunt, but I'm fairly >> > >> new to Fedora, so I didn't know you were actually working on >> stuff, and >> > >> not just someone asking for random commit access. >> > > > > Don't worry. I didn't get this wrong. I can understand you >> where > > worrying. If I'd be in your position, I would react >> differently. >> > > > >> I wouldn't worry too much about the linux-2.6- namespace >> for patches, >> > >> I'd prefer if they were just alpha-$patch.patch. davej, thoughts? >> > > > > Whatever you prefer. >> > > > > Let me know, so I start working on this today... >> > > Did I miss the answer to my mail!? >> >> Sorry, I was on vacation, and it fell off my radar when I got back. >> Looked ok to commit to me though iirc. >> >> I've no really preference on patch naming. If you want to do alpha-*, >> go ahead. >> but don't feel that you have to. > > OK. I'll commit the changes in a clean way, add CL, etc. > > We can still move the patches and use other names. Or any other change > that might be necessary... I've clean up my changes and finally commited them (F-9 only). Plz have a look at it and if it's fine for you, I go on with F-10. Best, Oliver From jwboyer at gmail.com Thu Mar 12 13:07:16 2009 From: jwboyer at gmail.com (Josh Boyer) Date: Thu, 12 Mar 2009 09:07:16 -0400 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <49B90722.4090901@linux-kernel.at> References: <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> <49AE34E9.3070901@linux-kernel.at> <49B77BDC.9060707@linux-kernel.at> <20090311133028.GA30421@redhat.com> <49B7BFC7.3010603@linux-kernel.at> <49B90722.4090901@linux-kernel.at> Message-ID: <20090312130716.GA2318@yoda.jdub.homelinux.org> On Thu, Mar 12, 2009 at 01:59:14PM +0100, Oliver Falk wrote: > Oliver Falk wrote: >> Dave Jones wrote: >>> On Wed, Mar 11, 2009 at 09:52:44AM +0100, Oliver Falk wrote: >>> > Oliver Falk wrote: >>> > > Hi! >>> > > > > Changed the subject, as happens that I oversee the mails :-( >>> > > And this subject is more descriptive, isn't it? >>> > > > > Kyle McMartin wrote: >>> > > [ ... ] >>> > >> This all looks fine to me. >>> > > > > May I interpret this as a *GO*? :-) >>> > > > > > Sorry to have been so blunt, but I'm fairly >>> > >> new to Fedora, so I didn't know you were actually working on >>> stuff, and >>> > >> not just someone asking for random commit access. >>> > > > > Don't worry. I didn't get this wrong. I can understand you >>> where > > worrying. If I'd be in your position, I would react >>> differently. >>> > > > >> I wouldn't worry too much about the linux-2.6- namespace >>> for patches, >>> > >> I'd prefer if they were just alpha-$patch.patch. davej, thoughts? >>> > > > > Whatever you prefer. >>> > > > > Let me know, so I start working on this today... >>> > > Did I miss the answer to my mail!? >>> >>> Sorry, I was on vacation, and it fell off my radar when I got back. >>> Looked ok to commit to me though iirc. >>> >>> I've no really preference on patch naming. If you want to do alpha-*, >>> go ahead. >>> but don't feel that you have to. >> >> OK. I'll commit the changes in a clean way, add CL, etc. >> >> We can still move the patches and use other names. Or any other change >> that might be necessary... > > I've clean up my changes and finally commited them (F-9 only). Plz have > a look at it and if it's fine for you, I go on with F-10. Looks like you committed them to CVS HEAD. The F-9 kernels are being built from a CVS branch (which is how they are still on 2.6.27). Is that what you intended? josh From oliver at linux-kernel.at Thu Mar 12 15:11:37 2009 From: oliver at linux-kernel.at (Oliver Falk) Date: Thu, 12 Mar 2009 16:11:37 +0100 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <20090312130716.GA2318@yoda.jdub.homelinux.org> References: <20090226182258.GA6502@redhat.com> <49A70B97.5010404@linux-kernel.at> <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> <49AE34E9.3070901@linux-kernel.at> <49B77BDC.9060707@linux-kernel.at> <20090311133028.GA30421@redhat.com> <49B7BFC7.3010603@linux-kernel.at> <49B90722.4090901@linux-kernel.at> <20090312130716.GA2318@yoda.jdub.homelinux.org> Message-ID: <49B92629.3000402@linux-kernel.at> Josh Boyer wrote: > On Thu, Mar 12, 2009 at 01:59:14PM +0100, Oliver Falk wrote: >> Oliver Falk wrote: >>> Dave Jones wrote: >>>> On Wed, Mar 11, 2009 at 09:52:44AM +0100, Oliver Falk wrote: >>>> > Oliver Falk wrote: >>>> > > Hi! >>>> > > > > Changed the subject, as happens that I oversee the mails :-( >>>> > > And this subject is more descriptive, isn't it? >>>> > > > > Kyle McMartin wrote: >>>> > > [ ... ] >>>> > >> This all looks fine to me. >>>> > > > > May I interpret this as a *GO*? :-) >>>> > > > > > Sorry to have been so blunt, but I'm fairly >>>> > >> new to Fedora, so I didn't know you were actually working on >>>> stuff, and >>>> > >> not just someone asking for random commit access. >>>> > > > > Don't worry. I didn't get this wrong. I can understand you >>>> where > > worrying. If I'd be in your position, I would react >>>> differently. >>>> > > > >> I wouldn't worry too much about the linux-2.6- namespace >>>> for patches, >>>> > >> I'd prefer if they were just alpha-$patch.patch. davej, thoughts? >>>> > > > > Whatever you prefer. >>>> > > > > Let me know, so I start working on this today... >>>> > > Did I miss the answer to my mail!? >>>> >>>> Sorry, I was on vacation, and it fell off my radar when I got back. >>>> Looked ok to commit to me though iirc. >>>> >>>> I've no really preference on patch naming. If you want to do alpha-*, >>>> go ahead. >>>> but don't feel that you have to. >>> OK. I'll commit the changes in a clean way, add CL, etc. >>> >>> We can still move the patches and use other names. Or any other change >>> that might be necessary... >> I've clean up my changes and finally commited them (F-9 only). Plz have >> a look at it and if it's fine for you, I go on with F-10. > > Looks like you committed them to CVS HEAD. The F-9 kernels are being built > from a CVS branch (which is how they are still on 2.6.27). Is that what > you intended? I didn't want to do it directly in private-fedora-9-2_6_27-branch with my first shot. I hope that's OK with? This way it's in CVS and I can build from it for testing. Now that I've seen it builds fine, I can go on and approach the 'real' tag... -of From kyle at infradead.org Thu Mar 12 15:15:21 2009 From: kyle at infradead.org (Kyle McMartin) Date: Thu, 12 Mar 2009 11:15:21 -0400 Subject: Alpha platform support for kernel package (WAS: Re: [pkgdb] kernel: oliver has requested commit) In-Reply-To: <49B92629.3000402@linux-kernel.at> References: <20090226214427.GA30098@redhat.com> <49A7CABF.9020801@linux-kernel.at> <20090228193202.GC28503@bombadil.infradead.org> <49AE34E9.3070901@linux-kernel.at> <49B77BDC.9060707@linux-kernel.at> <20090311133028.GA30421@redhat.com> <49B7BFC7.3010603@linux-kernel.at> <49B90722.4090901@linux-kernel.at> <20090312130716.GA2318@yoda.jdub.homelinux.org> <49B92629.3000402@linux-kernel.at> Message-ID: <20090312151521.GA15709@bombadil.infradead.org> On Thu, Mar 12, 2009 at 04:11:37PM +0100, Oliver Falk wrote: > I didn't want to do it directly in private-fedora-9-2_6_27-branch with > my first shot. I hope that's OK with? This way it's in CVS and I can > build from it for testing. Now that I've seen it builds fine, I can go > on and approach the 'real' tag... > Sure, sounds good to me. cheers, Kyle From markmc at redhat.com Mon Mar 23 14:27:26 2009 From: markmc at redhat.com (Mark McLoughlin) Date: Mon, 23 Mar 2009 14:27:26 +0000 Subject: Backport /sys/bus/pci/devices/*/remove_id Message-ID: <1237818446.3711.28.camel@blaa> Hey, Any objections to pulling in this patch from the linux-next PCI tree? It adds a sysfs entry which we need for KVM/libvirt PCI device assignment. See: https://bugzilla.redhat.com/487103 TODO entry would be: * linux-2.6-pci-sysfs-remove-id.patch In jbarnes linux-next tree for 2.6.30 Needed for KVM PCI device assignment https://bugzilla.redhat.com/487103 Cheers, Mark. From: Chris Wright Date: Tue, 24 Feb 2009 05:52:23 +0000 (-0800) Subject: PCI: add remove_id sysfs entry X-Git-Url: http://git.kernel.org/?p=linux%2Fkernel%2Fgit%2Fjbarnes%2Fpci-2.6.git;a=commitdiff_plain;h=0994375e9614f78657031e04e30019b9cdb62795 PCI: add remove_id sysfs entry This adds a remove_id sysfs entry to allow users of new_id to later remove the added dynid. One use case is management tools that want to dynamically bind/unbind devices to pci-stub driver while devices are assigned to KVM guests. Rather than having to track which driver was originally bound to the driver, a mangement tool can simply: Guest uses device Signed-off-by: Chris Wright Signed-off-by: Jesse Barnes --- diff --git a/Documentation/ABI/testing/sysfs-bus-pci b/Documentation/ABI/testing/sysfs-bus-pci index e638e15..3d29793 100644 --- a/Documentation/ABI/testing/sysfs-bus-pci +++ b/Documentation/ABI/testing/sysfs-bus-pci @@ -41,6 +41,22 @@ Description: for the device and attempt to bind to it. For example: # echo "8086 10f5" > /sys/bus/pci/drivers/foo/new_id +What: /sys/bus/pci/drivers/.../remove_id +Date: February 2009 +Contact: Chris Wright +Description: + Writing a device ID to this file will remove an ID + that was dynamically added via the new_id sysfs entry. + The format for the device ID is: + VVVV DDDD SVVV SDDD CCCC MMMM. That is Vendor ID, Device + ID, Subsystem Vendor ID, Subsystem Device ID, Class, + and Class Mask. The Vendor ID and Device ID fields are + required, the rest are optional. After successfully + removing an ID, the driver will no longer support the + device. This is useful to ensure auto probing won't + match the driver to the device. For example: + # echo "8086 10f5" > /sys/bus/pci/drivers/foo/remove_id + What: /sys/bus/pci/devices/.../vpd Date: February 2008 Contact: Ben Hutchings diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 93eac14..87a5ddb 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -99,6 +99,52 @@ store_new_id(struct device_driver *driver, const char *buf, size_t count) } static DRIVER_ATTR(new_id, S_IWUSR, NULL, store_new_id); +/** + * store_remove_id - remove a PCI device ID from this driver + * @driver: target device driver + * @buf: buffer for scanning device ID data + * @count: input size + * + * Removes a dynamic pci device ID to this driver. + */ +static ssize_t +store_remove_id(struct device_driver *driver, const char *buf, size_t count) +{ + struct pci_dynid *dynid, *n; + struct pci_driver *pdrv = to_pci_driver(driver); + __u32 vendor, device, subvendor = PCI_ANY_ID, + subdevice = PCI_ANY_ID, class = 0, class_mask = 0; + int fields = 0; + int retval = -ENODEV; + + fields = sscanf(buf, "%x %x %x %x %x %x", + &vendor, &device, &subvendor, &subdevice, + &class, &class_mask); + if (fields < 2) + return -EINVAL; + + spin_lock(&pdrv->dynids.lock); + list_for_each_entry_safe(dynid, n, &pdrv->dynids.list, node) { + struct pci_device_id *id = &dynid->id; + if ((id->vendor == vendor) && + (id->device == device) && + (subvendor == PCI_ANY_ID || id->subvendor == subvendor) && + (subdevice == PCI_ANY_ID || id->subdevice == subdevice) && + !((id->class ^ class) & class_mask)) { + list_del(&dynid->node); + kfree(dynid); + retval = 0; + break; + } + } + spin_unlock(&pdrv->dynids.lock); + + if (retval) + return retval; + return count; +} +static DRIVER_ATTR(remove_id, S_IWUSR, NULL, store_remove_id); + static void pci_free_dynids(struct pci_driver *drv) { @@ -125,6 +171,20 @@ static void pci_remove_newid_file(struct pci_driver *drv) { driver_remove_file(&drv->driver, &driver_attr_new_id); } + +static int +pci_create_removeid_file(struct pci_driver *drv) +{ + int error = 0; + if (drv->probe != NULL) + error = driver_create_file(&drv->driver,&driver_attr_remove_id); + return error; +} + +static void pci_remove_removeid_file(struct pci_driver *drv) +{ + driver_remove_file(&drv->driver, &driver_attr_remove_id); +} #else /* !CONFIG_HOTPLUG */ static inline void pci_free_dynids(struct pci_driver *drv) {} static inline int pci_create_newid_file(struct pci_driver *drv) @@ -132,6 +192,11 @@ static inline int pci_create_newid_file(struct pci_driver *drv) return 0; } static inline void pci_remove_newid_file(struct pci_driver *drv) {} +static inline int pci_create_removeid_file(struct pci_driver *drv) +{ + return 0; +} +static inline void pci_remove_removeid_file(struct pci_driver *drv) {} #endif /** @@ -852,13 +917,23 @@ int __pci_register_driver(struct pci_driver *drv, struct module *owner, /* register with core */ error = driver_register(&drv->driver); if (error) - return error; + goto out; error = pci_create_newid_file(drv); if (error) - driver_unregister(&drv->driver); + goto out_newid; + error = pci_create_removeid_file(drv); + if (error) + goto out_removeid; +out: return error; + +out_removeid: + pci_remove_newid_file(drv); +out_newid: + driver_unregister(&drv->driver); + goto out; } /** @@ -874,6 +949,7 @@ int __pci_register_driver(struct pci_driver *drv, struct module *owner, void pci_unregister_driver(struct pci_driver *drv) { + pci_remove_removeid_file(drv); pci_remove_newid_file(drv); driver_unregister(&drv->driver); pci_free_dynids(drv); From cebbert at redhat.com Mon Mar 23 21:07:39 2009 From: cebbert at redhat.com (Chuck Ebbert) Date: Mon, 23 Mar 2009 17:07:39 -0400 Subject: File conflicts between alsa-firmware and kernel-firmware In-Reply-To: <200903031607.39069.jarod@redhat.com> References: <49A96ABD.4060608@timj.co.uk> <200903031607.39069.jarod@redhat.com> Message-ID: <20090323170739.748fa48b@dhcp-100-2-144.bos.redhat.com> On Tue, 3 Mar 2009 16:07:38 -0500 Jarod Wilson wrote: > > > - Is there a long term goal to bring all the firmware from alsa-firmware > > upstream into the kernel-firmware package? > > No clue... Would have to talk to some alsa folks. > David Woodhouse is working on firmware packaging. He just did a new package: http://www.kernel.org/pub/linux/kernel/people/dwmw2/firmware/linux-firmware-20090319.tar.bz2 Tim, you might want to ask if he's going to put the ALSA firmware in there. From vicanderson at gmail.com Tue Mar 24 20:17:24 2009 From: vicanderson at gmail.com (Victor) Date: Tue, 24 Mar 2009 16:17:24 -0400 Subject: Patch incomplete write error not returned to NFS client Message-ID: Request for integrating this patch into the next kernel update for Fedora 10. The patch fixes a bug in NFS where an error will not be returned to the NFS client when an incomplete write happens at the filesystem level on the server. http://git.linux-nfs.org/?p=bfields/linux.git;a=commitdiff;h=192a3cb6bc1f12a0af55bcf2fbb6e923d48a5b58;hp=82f69c6c0efae204dbf428f5c93fcc8d088696c2 --Vic From markmc at redhat.com Mon Mar 30 09:03:38 2009 From: markmc at redhat.com (Mark McLoughlin) Date: Mon, 30 Mar 2009 10:03:38 +0100 Subject: rpms/kernel/devel linux-2.6-net-fix-another-gro-bug.patch, NONE, 1.1 TODO, 1.59, 1.60 kernel.spec, 1.1482, 1.1483 In-Reply-To: <20090330085640.8037770136@cvs1.fedora.phx.redhat.com> References: <20090330085640.8037770136@cvs1.fedora.phx.redhat.com> Message-ID: <1238403818.854.41.camel@blaa> Hi, On Mon, 2009-03-30 at 08:56 +0000, Mark McLoughlin wrote: > +* linux-2.6-net-fix-another-gro-bug.patch: > + virtio_net guest->remote GSO busted with 2.6.29 host > + https://bugzilla.redhat.com/490266 > + Should be in 2.6.29.1 I took the liberty of just going ahead and building this - pretty serious bug with a fairly trivial fix from upstream. Cheers, Mark. From kyle at mcmartin.ca Tue Mar 31 15:37:36 2009 From: kyle at mcmartin.ca (Kyle McMartin) Date: Tue, 31 Mar 2009 11:37:36 -0400 Subject: early branched for F-11 Message-ID: <20090331153736.GB15550@bombadil.infradead.org> Just a quick note, we've early branched for F-11... The 2.6.29 based tree for F-11 is located in the F-11/ subdirectory... Make sure you cvs up the common/ dir as well. devel/ has been updated for -git7 and will continue to move towards 2.6.30. regards, Kyle