Slmodem in fc5

[Antonio Olivares]

--- "S. Cesaretti" <s.cesaretti at all4linux.net> wrote:

> Hello,
> I need to install the slmodem driver to use the
> internal modem of my 
> notebook in fedora core 5.
> Is there anybody that use this driver?
> because I can't compile it with the kernel 2.6.13
> and 2.6.16.
> How can I do that?
> Is there any patch for that?
> Thanks in advance for all information
> Best regards
> Sauro
> 
> 
> -- 
> fedora-list mailing list
> fedora-list at redhat.com
> To unsubscribe:
> https://www.redhat.com/mailman/listinfo/fedora-list
> 

http://linmodems.org/cgi-bin/ezmlm-cgi?1:msp:23239:iclijmpbhhdoahfcbpkf

Hello Sasha,

this message is CC:ed to discuss at linmodems.org, in
case anyone there can 
use them in the meantime.

With current kernels, the slmodem-2.9.11-20051101
kernel drivers won't 
compile.
The problems are twofold. One is the following problem
in st7554.c:

error: unknown field 'owner' specified in initializer
warning: initialization from incompatible pointer type

And the other is that the the compiled modules cannot
be inserted in the 
kernel:

slamr: falsely claims to have parameter debug
slusb: falsely claims to have parameter debug


Attached you'll find two patches, the first #ifdefing
the owner field with 
certain kernel releases, specifically 2.6.16 and
later, and the second 
patch changing the deprecated MODULE_PARM to the
current module_param 
format.

Applying these patches makes the kernel drivers work:

slamr: SmartLink AMRMO modem.
slamr: probe 8086:24c6 ICH4 card...
ACPI: PCI Interrupt 0000:00:1f.6[B] -> GSI 17 (level,
low) -> IRQ 17
PCI: Setting latency timer of device 0000:00:1f.6 to
64
slamr: mc97 codec is SIL27
slamr: slamr0 is ICH4 card.


These two patches will be used for the new
slmodem-kmod package at 
rpm.livna.org but you might also be interested in
adding them to your 
tree.

regards,
 Andreas

--- slmodem-2.9.11-20051101/drivers/st7554.c.owner
2006-04-28 14:43:27.000000000 +0200
+++ slmodem-2.9.11-20051101/drivers/st7554.c
2006-04-28 14:43:27.000000000 +0200
@@ -1150,7 +1150,9 @@
 MODULE_DEVICE_TABLE (usb, st7554_ids);
 
 static struct usb_driver st7554_usb_driver = {
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,0) &&
LINUX_VERSION_CODE < KERNEL_VERSION(2,6,16)
 	.owner =       THIS_MODULE,
+#endif
 	.name =	       "ST7554 USB Modem",
 	.probe =       st7554_probe,
 	.disconnect =  st7554_disconnect,

--- slmodem-2.9.11-20051101/drivers/old_st7554.c.orig
2006-04-28 17:22:01.000000000
+0200
+++ slmodem-2.9.11-20051101/drivers/old_st7554.c
2006-04-28 17:22:20.000000000 +0200
@@ -74,7 +74,7 @@
 #define MY_MAJOR 243
 
 static int debug = 0;
-MODULE_PARM(debug,"i");
+module_param(debug, int, 1);
 MODULE_PARM_DESC(debug,"Debug level: 0-3
(default=0)");
 
 /* st7554 IDs */
--- slmodem-2.9.11-20051101/drivers/st7554.c.orig
2006-04-28 17:21:56.000000000 +0200
+++ slmodem-2.9.11-20051101/drivers/st7554.c
2006-04-28 17:22:20.000000000 +0200
@@ -76,7 +76,7 @@
 #define USB_DBG_URB(fmt...) // USB_DBG(fmt)
 
 static int debug = 0;
-MODULE_PARM(debug,"i");
+module_param(debug, int, 1);
 MODULE_PARM_DESC(debug,"Debug level: 0-3
(default=0)");
 
 /* st7554 IDs */
--- slmodem-2.9.11-20051101/drivers/amrmo_init.c.orig
2006-04-28 17:22:08.000000000
+0200
+++ slmodem-2.9.11-20051101/drivers/amrmo_init.c
2006-04-28 17:22:20.000000000 +0200
@@ -701,7 +701,7 @@
  *  module stuff
  */
 
-MODULE_PARM(debug,"i");
+module_param(debug, int, 1);
 MODULE_PARM_DESC(debug,"debug level: 0-3
(default=0)");
 
 MODULE_AUTHOR("Smart Link Ltd.");


Regards,

Antonio

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com