Problem building RPM

[Bill Crawford]

On Thursday 19 February 2009 15:27:15 Mike Martin wrote:
> Hi I am haaving a problem building a rpm for vlc 0.9.8 (spec file attached)
>
> The same spec file works for vlc 0.8.6*
>
> The final output is
>
> Binary file
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/lib/vlc/visualizat
>ion/libvisual_plugin.so matches
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/rvlc:exec
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/vlc -I
> "rc" "$@"
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/nvlc:exec
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/vlc -I
> "ncurses" "$@"
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/svlc:exec
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/vlc -I
> "skins2" "$@"
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/qvlc:exec
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/vlc -I
> "qt4" "$@"
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/cvlc:exec
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/vlc -I
> "dummy" "$@"
> Binary file
> /home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386/usr/bin/vlc matches
> Found '/home/mike/rpmbuild/BUILDROOT/vlc-0.9.8a-ffmpeg.i386' in
> installed files; aborting
> error: Bad exit status from /var/tmp/rpm-tmp.3P5LVn (%install)
>
>
> RPM build errors:
>     Bad exit status from /var/tmp/rpm-tmp.3P5LVn (%install)
>
> Log filee attached (bziped)

Get rid of the %makeinstall, and use something "make install 
DESTDIR=%{buildroot}" instead (I think that's the correct spelling, but just 
look through a few specs to find one that does it right).

Basically %makeinstall passes the install directory to the make command in a way 
that sometimes causes the build root to be included in substitutions, wrongly. 
While this is, arguably, bad behaviour (as all building ought to be done in the 
original "make" command), it's also not the best way to pass a staging dir to 
the install command, and the autotools documentation used to mention this way 
as the way to do it. Plus, it normally works, and %makeinstall sometimes fails.