[Fedora-livecd-list] [PATCH] Use string methods instead of the string module

Jeremy Katz katzj at redhat.com
Mon Dec 17 16:55:11 UTC 2007


On Sun, 2007-12-16 at 23:58 +0800, Tan Swee Heng wrote:
> According to "pydoc string", the string module isn't normally used nowadays.
> PEP 290 (http://www.python.org/dev/peps/pep-0290/#string-methods) also
> recommends using string methods over the string module because
>   i. the string module may be deprecated in future;

Not until python 3k at least, and for that, a whole lot more is going to
break.

>  ii. string methods are faster.

Speed isn't really a concern here.

> This patch converts the imgcreate code to use string methods instead of the
> string module.

I'm not really against this, but at the same time, I've always thought
that
  " ".join()
is pretty ugly and non-obvious, so I'd rather leave string.join for
there.  The split case is clear enough, though

Jeremy




More information about the Fedora-livecd-list mailing list