[Fedora-livecd-list] [PATCH] error handling fixes

Jeremy Katz katzj at redhat.com
Tue Mar 20 15:21:39 UTC 2007


Close the rpmdb in case of errors installing packages so that we don't
get an error on unmounts.  Also, don't print multiple errors if we've
exited on a package installation failure
---
 creator/livecd-creator |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/creator/livecd-creator b/creator/livecd-creator
index 50a8036..77a61be 100755
--- a/creator/livecd-creator
+++ b/creator/livecd-creator
@@ -470,7 +470,8 @@ class InstallationTarget:
             self.ayum.runInstall()
         except Exception, e:
             print "Error installing packages"
-            traceback.print_exc(file=sys.stderr)            
+            traceback.print_exc(file=sys.stderr)
+            self.ayum.closeRpmDB()            
             return False
         self.ayum.closeRpmDB()
         return True
@@ -849,6 +850,8 @@ def main():
         if ksparser.handler.selinux.selinux:
             target.relabelSystem()
         target.configureBootloader()
+    except SystemExit:
+        sys.exit(1)
     except:
         print "\n\nERROR during installation..."
         traceback.print_exc(file=sys.stderr)
-- 
1.5.0.2




More information about the Fedora-livecd-list mailing list