[Fedora-livecd-list] [patch 06/20] Cleanup unmount() and teardown()

[Mark McLoughlin]

On Tue, 2007-03-27 at 11:23 -0400, Jeremy Katz wrote:
> On Tue, 2007-03-27 at 15:14 +0100, Mark McLoughlin wrote:
> >      def unmount(self):
> >          """detaches system bind mounts and install_root for the file system and tears down loop devices used"""
> > +        shutil.rmtree(self.build_dir + "/yum-cache", ignore_errors=True)
> 
> Doesn't this end up removing the contents of all of your yum cache
> (which gets bind mounted from your host)?

	No, this dir isn't bind-mounted from the host, we create a fresh cache
for each run - note, this rmtree() is in the original code.

	This does seem a bit odd, though, I'll grant you. You'd think you'd
want to re-use a yum cache between runs ...

Cheers,
Mark.