[Fedora-livecd-list] [PATCH]: Fix --base-on

[Douglas McClendon]

Chris Lalancette wrote:
> All,
>      I'm working with the latest version of livecd-creator available in rawhide,
> which is livecd-tools-012-1.fc8.  I noticed a bug when using the --base-on
> option; basically, it is testing for the existence of the squashfs.img, but that
> path can't possibly exist until the ISO has been loopback mounted.  The attached
> patch moves the mounting of the ISO before the check to see if the squashfs
> filesystem exists.  With this patch, I am able to successfully use the --base-on
> option.

TODO: since livecd-tools was added to the dev-spin, it seems like the 
most obvious minimal QA that should be done is to boot an RC of the 
dev-livecd, mount some tmpspace, and then run livecd-creator (with 
--tmpdir) with --base-on pointing at /dev/live, to see if you can easily 
perform some minimal respin.  E.g. perhaps just kickstart that adds a 
couple new packages, maybe adds a 3rd party repo, and changes the 
isolinux splash.  And as a second QA test, respin itself without the 
base-on option.

And I would love it if the dev-livecd could include qemu (space 
impact?), so that the resulting livecd's could be virtually test booted 
trivially.

-dmc