[Fedora-livecd-list] A couple of cleanup patches

[Mark McLoughlin]

On Mon, 2007-09-03 at 22:09 -0500, Douglas McClendon wrote:
> Mark McLoughlin wrote:
> > 
> > 	Second patch refactors the resize2fs stuff so that it is substantially
> > easier to understand - e.g. trying to grok the binary search in
> > resize2fsToMinimal() is a lot easier than the original version in
> > cleanupDeleted() ...
> 
> Couple more things, which I'm still just going off of visual inspection 
> of the patch-
> 
> 
> +    def package(self, ignore_deleted = False):
> +        if ignore_deleted:
> +            self.cleanupDeleted()
> 
> I think you meant "if not ignore_deleted"
> 
> And I'm also confused by final_size_mb in general.
> 
> +        if not final_size_mb is None:
> +            n_blocks = final_size_mb * 1024L * 1024L / self.blocksize
> 
> 
> Where does it get set to anything other than None?

	Bah, well spotted - both of these I removed before sending the patch,
but then sent the wrong patch. Here's the correct patch.

Cheers,
Mark.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: creator-refactor-cleanup-deleted.patch
Type: text/x-patch
Size: 5878 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-livecd-list/attachments/20070904/25074f36/attachment.bin>