[Fedora-livecd-list] [PATCH] disable mksquashfs progress bar for non-interactive sessions

[Douglas McClendon]

This patch introduces a global variable 'interactive' which is defined
as true if stdout of livecd-creator is attached to a tty.  This global
is then used to add the -no-progress option to mksquashfs for
non-interactive sessions.  Thus making logfiles created by redirecting
the output of livecd-creator, reasonably readable (e.g. with less).

This may or may not solve the root issue that Jon Steer recently brought
up.  (maybe he wants it disabled even in terminal situation, in which
case a --verbose/--debug/--quiet infrastructure is called for, which IMO
would be a great addition as well).

This specific case, might also be better as an upstream mksquashfs
modification (Phillip, should I submit a patch?), but I think the global
is handy, for instance if we want to provide our own progress bar.

Comments welcome on generic style issues as always (is there something
preferable to a global in this instance?)

-dmc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: livecd.interactive.patch
Type: text/x-patch
Size: 1292 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-livecd-list/attachments/20070923/f343d3a4/attachment.bin>