[Fedora-livecd-list] [PATCH] Partition Size overriding

[Jeroen van Meeuwen]

Hello there,

while spinning a Games DVD -just for kicks-, I found that the "part / 
8000" in it's kickstart isn't really applied.

Using ksflatten shows me the "part" statements are appended to one 
another, depending on the other they have been specified; if "part / 
8000" is specified before including the 'base' kickstart, the filesystem 
will end up size 8000*1024L*1024L. Either way:

Attached are two patches:

partition_size_last-specified.patch makes livecd-tools loop through 
/all/ the partition statements, and takes the size of last "part /" 
specified so that the "part /" statement becomes something that can be 
overridden. I'm not sure how valid this is, as sorting "part" statements 
in pykickstart may result in unsuspected behavior on livecd-tool's part.

partition_size_largest.patch however takes all "part /" statements into 
consideration, and picks the largest.

Another valid solution would be to have 'base' kickstarts specify the 
filesystem size and, by (Spin SIG?) policy, not allowing any overrides 
of this part of 'base'.

Kind regards,

Jeroen van Meeuwen
-kanarip

-------------- next part --------------
A non-text attachment was scrubbed...
Name: partition_size_largest.patch
Type: text/x-patch
Size: 2050 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-livecd-list/attachments/20080425/2e732400/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: partition_size_last-specified.patch
Type: text/x-patch
Size: 680 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/fedora-livecd-list/attachments/20080425/2e732400/attachment-0001.bin>