Checking in packages for extras

Oliver Falk oliver at linux-kernel.at
Fri Apr 22 13:04:40 UTC 2005


> On Fri, 2005-04-22 at 10:36 +0200, Oliver Falk wrote:
> > > > > Hey folks,
> > > > >  when you check in a package/changes that you're going to 
> > > > > request to be built, please run 'make tag' in the directory 
> > > > > you're checking in.
> > > > 
> > > > The easiest way to do that is to write the build: line in 
> > > > Makefile.common as
> > > > "build: tag", so it will tag it automatically. :-)
> > > 
> > > This will fail if it is tagged already (many of us Red 
> > > Hatters will 
> > > run make tag on one machine and make build on another courtesy of 
> > > our internal build system).
> > 
> > Yes, I encountered this problem allready, but that's the 
> > reason, why I 
> > 'move' the cvs tag. So my cvs tag line reads as:
> > 
> > cvs tag -F $(TAG_OPTS) -c $(TAG)
> > 
> > (As you can see I added -F).
> 
> I see, but this is not what we want, trust me on that one ;-).
> Force-tagging should only be done if really necessary, not 
> per default.

I trust you! :-)
 
> > That works fine here. I'm sure, that you, Red Hatters, do work this 
> > way and I also work this way very often, but for the most 
> > people out 
> > there - I guess
> > - they run tag and build on the same machine!?
> > 
> > The reason why I always tag it before building, is that I cannot 
> > forget it then. :-)
> 
> Well our build system checks for the presence of the tag 
> before building, maybe someone can patch Seth accordingly ;-).

OK, OK. You are all correct. Forcing it should be done with thinking what
doing, not automatically.

At my site, I don't mind... :-)

Best,
 Oliver




More information about the Fedora-maintainers mailing list