The open() system call in f8 really broken...

Steve Dickson SteveD at redhat.com
Thu Aug 16 20:36:03 UTC 2007


Pete Zaitcev wrote:
> 
>> - if ((fd = open(fname, readonly? O_RDONLY : (O_RDWR|O_CREAT))) < 0) {
>> + if ((fd = (open)(fname, readonly? O_RDONLY : (O_RDWR|O_CREAT))) < 0) {
> 
> Now you're just being unfriendly about it by finding ways to defeat
> a helpful check instead of adding the missing mode. What point are
> you trying to prove by doing this?
The point I was trying to prove  is by simply adding the '()' I
could avoid the runtime abort and still have the security hole....
concluding  the runtime check is very buggy so this check should
never call abort() since it can't be correct 100% of time...

steved.




More information about the Fedora-maintainers mailing list