[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: The open() system call in f8 really broken...



Jakub Jelinek wrote:
> On Thu, Aug 16, 2007 at 10:12:24AM -0400, Steve Dickson wrote:
>> Bring down servers, costing people time and money because apps
>> that have run for years suddenly abort is just not the right
>> way to handle this.. imho..
> 
> Only people that run their $$$$$$ servers on rawhide...
> 
>> Give people a chance to correct their code, with stern warnings,
>> and then, in the next release, have the applications abort...
>> Why is this such a bad idea?
> 
> It is not yet F8test2, there is plenty of time to fix all or most
> of these bugs still in rawhide.
> Most uses of open(1) are actually with compile time constant
> second argument and in that case glibc will issue compile time
> errors when open ("foo", O_CREAT|O_RDWR); etc. is seen.
> Only when it is known only at runtime we do runtime checking.


Hmm is that what killed my e2sfprogs build?  This looks like a bug in
the check:


   195  memset(data, 0, sizeof(struct test_private_data));
   196  data->magic = EXT2_ET_MAGIC_TEST_IO_CHANNEL;
   197  if (test_io_backing_manager) {
   198          retval = test_io_backing_manager->open(name, flags,
   199                                                 &data->real);
   200             if (retval)
   201                     goto cleanup;
   202  } else
   203             data->real = 0;

test_io.c: In function 'test_open':
test_io.c:198: error: expected identifier before '(' token
make[2]: *** [test_io.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory
`/builddir/build/BUILD/e2fsprogs-1.40.2/lib/ext2fs'
make[1]: *** [all-libs-recursive] Error 1
make[1]: Leaving directory `/builddir/build/BUILD/e2fsprogs-1.40.2'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.43284 (%build)

Note that it will probably stumble on a bona-fide
open-create-with-no-mode later ;-)

-Eric


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]