[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: The open() system call in f8 really broken...



On Thu, 2007-08-16 at 17:48 -0500, Eric Sandeen wrote:
> Roland McGrath wrote:
> >> One unfortunate side-effect of this is that cscope doesn't find these as
> >> "open" callers now.  Maybe I need a smarter cscope.  It gets it to
> >> build, though.
> > 
> > Yes, cscope should learn C.
> > 
> >>> retval = test_io_backing_manager->(open)(name, flags, &data->real);
> >> FWIW this didn't help, build failed same as before.
> > 
> > I'm not sure we believe you.
> 
> sorry, different failure.
> 
> test_io.c: In function ‘test_open’:
> test_io.c:198: error: expected identifier before ‘(’ token
> make[2]: *** [test_io.o] Error 1
> 
> bash-3.2# cat -n lib/ext2fs/test_io.c | grep 198
>    198                  retval = test_io_backing_manager->(open)(name,
> flags, &data->real);
> 
> *shrug* maybe I'm just dense and/or worn out today.  I'll go with what
> works.

Imo the "right" fix should be to not use "open" as I'd consider it a
reserved word, and change it to something like tio_open ... cscope would
be happy as well.

Simo.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]