The open() system call in f8 really broken...

Nils Philippsen nphilipp at redhat.com
Fri Aug 17 13:29:20 UTC 2007


On Thu, 2007-08-16 at 19:06 -0400, Dave Jones wrote:

> Checking ./sane-backends/sane-backends-1.0.18/backend/fujitsu.c
> Found open with O_CREAT and no mode.
>       s->duplex_fd = open (filename, O_RDWR | O_CREAT | O_EXCL);

That's bogus. This line contains a correct sibling that'd be active if
_POSIX_SOURCE were defined... if it wasn't in a huge commented out block
anyway ;-).

Nils
-- 
     Nils Philippsen    /    Red Hat    /    nphilipp at redhat.com
"Those who would give up Essential Liberty to purchase a little
Temporary
 Safety, deserve neither Liberty nor Safety."  --  B. Franklin, 1759
 PGP fingerprint:  C4A8 9474 5C4C ADE3 2B8F  656D 47D8 9B65 6951 3011




More information about the Fedora-maintainers mailing list