Eliminate "Bouncing" in Reviews

Dominik 'Rathann' Mierzejewski dominik at greysector.net
Thu Feb 8 21:18:05 UTC 2007


On Thursday, 08 February 2007 at 05:20, Warren Togami wrote:
> New thought.
> 
> Possibly this compromise process satisfies both camps, by eliminating 
> "bouncing" back and forth, while being assigned to the next actor, and 
> making logical use of NEEDINFO.
> 
> 1) State 1: Not Yet Reviewed
> ASSIGNED pointer to nobody at fedoraproject.org
> 
> 2) State 2: Under Review
> ASSIGNED pointer to Reviewer
> 	When fedora-review? or fedora-review-
> 	Use NEEDINFO to request owner to fix something.

Again: shouldn't fedora-review- be a rather permanent state? I admit
that I don't entirely understand the purpose of those flags, whatever they
are.

> 3) State 3: Approved
> ASSIGNED pointer to Owner
> 	ONLY when fedora-review+

Leave assigned to reviewer, please. It's illogical to change it.

> Benefits
> ========
> - No bouncing back and forth between reviewer and owner.
> - http://rubenkerkhof.com/review
> This page continues to show under "Assigned" who is acting.
> - frontpage.cgi shows both ASSIGNED and NEEDINFO for appropriate actors 
> both during and after the review.

Good!

Regards,
R.

-- 
Fedora Extras contributor  http://fedoraproject.org/wiki/DominikMierzejewski
Livna contributor http://rpm.livna.org MPlayer developer http://mplayerhq.hu
"Faith manages."
        -- Delenn to Lennier in Babylon 5:"Confessions and Lamentations"




More information about the Fedora-maintainers mailing list