Review guidelines and rpmlint

[Callum Lerwick]

On Fri, 2007-03-09 at 11:50 -0500, Chip Coldwell wrote:
> Yes.  In order to meet the merge review requirements for Fedora 7 I must 
> silence rpmlint.

I keep seeing this over and over and over and over and over and over and
over and over and over and over and over and over and over again.

If you look closely, rpmlint output is separated into warnings (W:) and
errors (E:). Just like a C compiler.

IMHO we should do this:

Errors MUST be fixed to pass review. (Or to pass the upcoming
rpmlint-after-build test)

Warnings can be ignored IF (BIG IF) there is reasonable justification.
For example, the common "no documentation" warning with sub-packages
such as -devel. Often all documentation goes into the main package, and
there's nothing suited to go in the -devel package.

And if rpmlint flags something as an error that shouldn't be, file a bug
against rpmlint. The test can be revised, or downgraded to a warning.

... Is this an agreeable revision to the review guidelines?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/fedora-maintainers/attachments/20070311/4427ca0c/attachment.sig>