Ex-Core package Makefile.common problem in CVS

[Ville Skyttä]

On Saturday 12 May 2007, Ignacio Vazquez-Abrams wrote:
> On Sat, 2007-05-12 at 12:30 +0300, Ville Skyttä wrote:
> > After checking out "rpms" from cvs.fedora.redhat.com:/cvs/pkgs, ex-Core
> > package branch Makefiles have issues finding Makefile.common.  Ex-Extras
> > packages don't have that problem - looks like "find-makefile-common"
> > stuff or something similar should be applied to ex-Core branch Makefiles
> > too.
> >
> > For example:
> > $ cd shadow-utils/devel
> > $ make prep
> > Makefile:6: ../common/Makefile.common: No such file or directory
> > make: *** No rule to make target `../common/Makefile.common'.  Stop.
>
> Confirmed. And changing the line in Makefile
> to ../../../common/Makefile.common doesn't work since it gives all sorts
> of other problems.

Hmm, I've been changing it to ../../common/Makefile.common and have had some 
success.  Anyway I got tired of doing that and ran this dirty script to fix 
them all locally (including F-7 branches which seem to have inherited the 
same problem during branching):

#!/bin/sh
for pkg in * ; do
    for branch in F-7 devel ; do
        [ -f $pkg/$branch/Makefile ] || continue
        echo $pkg/$branch/Makefile
        grep -qF find-makefile-common $pkg/$branch/Makefile || \
        sed -e "s/rpmdevtools/$pkg/g" rpmdevtools/$branch/Makefile \
        > $pkg/$branch/Makefile
    done
done