From marc at mwiriadi.id.au Sun Jun 10 04:19:53 2007 From: marc at mwiriadi.id.au (Marc Wiriadisastra) Date: Sun, 10 Jun 2007 12:19:53 +0800 Subject: [Fedora-mentors-list] adesklets.spec Message-ID: <1181449193.29027.1.camel@localhost.localdomain> Does someone want to have a look over this spec file to see where I went wrong. Also how do I know whether a devel package is required to be created or not? I've noticed a few people asking about adesklets so I thought I would try my hand in packaging it. I haven't created a desktop file or anything like that I'm more concerned with the basic install. Regards, Marc -------------- next part -------------- A non-text attachment was scrubbed... Name: adesklets.spec Type: text/x-rpm-spec Size: 1608 bytes Desc: not available URL: From marc at mwiriadi.id.au Sun Jun 10 04:52:46 2007 From: marc at mwiriadi.id.au (Marc Wiriadisastra) Date: Sun, 10 Jun 2007 12:52:46 +0800 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: <1181449193.29027.1.camel@localhost.localdomain> References: <1181449193.29027.1.camel@localhost.localdomain> Message-ID: <1181451166.29027.3.camel@localhost.localdomain> On Sun, 2007-06-10 at 12:19 +0800, Marc Wiriadisastra wrote: > Does someone want to have a look over this spec file to see where I went > wrong. > > Also how do I know whether a devel package is required to be created or > not? > > I've noticed a few people asking about adesklets so I thought I would > try my hand in packaging it. I haven't created a desktop file or > anything like that I'm more concerned with the basic install. > Double post but I have removed gcc etc from the list here http://fedoraproject.org/wiki/Packaging/FullExceptionList -------------- next part -------------- A non-text attachment was scrubbed... Name: adesklets.spec Type: text/x-rpm-spec Size: 1588 bytes Desc: not available URL: From sheltren at cs.ucsb.edu Sun Jun 10 11:24:11 2007 From: sheltren at cs.ucsb.edu (Jeff Sheltren) Date: Sun, 10 Jun 2007 07:24:11 -0400 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: <1181451166.29027.3.camel@localhost.localdomain> References: <1181449193.29027.1.camel@localhost.localdomain> <1181451166.29027.3.camel@localhost.localdomain> Message-ID: <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> On Jun 10, 2007, at 12:52 AM, Marc Wiriadisastra wrote: > > > Double post but I have removed gcc etc from the list here > http://fedoraproject.org/wiki/Packaging/FullExceptionList > > > Hi Marc, I took a look at your spec file. Now, keep in mind that I don't often (ie. ever) do package reviews, but here's my advise FWIW: Overall the spec looks very good. I did make a few changes which I outline below and are in the attached spec file. Once you get your package built, I would also recommend running rpmlint against it to see what it says. -Use macros for perl, python directories. Add the python macro definition at the top of the spec; perl macro is already defined in rpm. -Source0 should be a full URL -I think that naming the patch with the package name-version is helpful -Try building your package without the 'Requires' line and see if rpmbuild is able to automatically pull in requires for at least perl & python (I think it will). -Change %patch to %patch0 Let me know if you have any questions. -Jeff -------------- next part -------------- A non-text attachment was scrubbed... Name: adesklets.spec Type: application/octet-stream Size: 1501 bytes Desc: not available URL: From sheltren at cs.ucsb.edu Sun Jun 10 11:26:34 2007 From: sheltren at cs.ucsb.edu (Jeff Sheltren) Date: Sun, 10 Jun 2007 07:26:34 -0400 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> References: <1181449193.29027.1.camel@localhost.localdomain> <1181451166.29027.3.camel@localhost.localdomain> <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> Message-ID: On Jun 10, 2007, at 7:24 AM, Jeff Sheltren wrote: > On Jun 10, 2007, at 12:52 AM, Marc Wiriadisastra wrote: >> >> >> Double post but I have removed gcc etc from the list here >> http://fedoraproject.org/wiki/Packaging/FullExceptionList >> >> >> > > Hi Marc, I took a look at your spec file. Now, keep in mind that I > don't often (ie. ever) do package reviews, but here's my advise FWIW: One more thing, I noticed that the adesklet site mentions a patch to prevent segfaults in the latest version. Is that needed for any Fedora versions? -Jeff From marc at mwiriadi.id.au Sun Jun 10 12:25:07 2007 From: marc at mwiriadi.id.au (Marc Wiriadisastra) Date: Sun, 10 Jun 2007 20:25:07 +0800 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: References: <1181449193.29027.1.camel@localhost.localdomain> <1181451166.29027.3.camel@localhost.localdomain> <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> Message-ID: <1181478307.4772.4.camel@localhost.localdomain> On Sun, 2007-06-10 at 07:26 -0400, Jeff Sheltren wrote: > On Jun 10, 2007, at 7:24 AM, Jeff Sheltren wrote: > > > On Jun 10, 2007, at 12:52 AM, Marc Wiriadisastra wrote: > >> > >> > >> Double post but I have removed gcc etc from the list here > >> http://fedoraproject.org/wiki/Packaging/FullExceptionList > >> > >> > >> > > > > Hi Marc, I took a look at your spec file. Now, keep in mind that I > > don't often (ie. ever) do package reviews, but here's my advise FWIW: > > One more thing, I noticed that the adesklet site mentions a patch to > prevent segfaults in the latest version. Is that needed for any > Fedora versions? > > -Jeff > > -- I appreciate the feedback Jeff. I'm getting errors relating to the following perl macro's placed in the %file section. RPM build errors: File must begin with "/": %{_perl_sitelib}/* File must begin with "/": %{_perl_vendorlib}/perllocal.pod File must begin with "/": %{_perl_vendorarch}/auto/adesklets/ File must begin with "/": %{_perl_vendorarch}/auto/adesklets/.packlist Also the RPM that I created before with the SPEC file that I emailed to the list compiled and created the RPM I installed it and ran the resultant program and I couldn't get it to segfault. Not that I tested it to thoroughly. Do you have a link to the explaining of the macro's so I can understand them better? The only reason I added python and perl was because the fresh install I did with the i686 didn't have perl and python in. When I updated it, it worked but yeah I'll test it. Again appreciate the feedback I'll have a further play with it but direction for reading would be appreciated :) Cheers, Marc From sheltren at cs.ucsb.edu Sun Jun 10 13:10:40 2007 From: sheltren at cs.ucsb.edu (Jeff Sheltren) Date: Sun, 10 Jun 2007 09:10:40 -0400 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: <1181478307.4772.4.camel@localhost.localdomain> References: <1181449193.29027.1.camel@localhost.localdomain> <1181451166.29027.3.camel@localhost.localdomain> <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> <1181478307.4772.4.camel@localhost.localdomain> Message-ID: <4A5B4050-B3C9-4D87-88E1-68B85218F75A@cs.ucsb.edu> On Jun 10, 2007, at 8:25 AM, Marc Wiriadisastra wrote: > > I appreciate the feedback Jeff. I'm getting errors relating to the > following perl macro's placed in the %file section. > > RPM build errors: > File must begin with "/": %{_perl_sitelib}/* > File must begin with "/": %{_perl_vendorlib}/perllocal.pod > File must begin with "/": %{_perl_vendorarch}/auto/adesklets/ > File must begin with "/": > %{_perl_vendorarch}/auto/adesklets/.packlist > > Also the RPM that I created before with the SPEC file that I > emailed to > the list compiled and created the RPM I installed it and ran the > resultant program and I couldn't get it to segfault. Not that I > tested > it to thoroughly. > > Do you have a link to the explaining of the macro's so I can > understand > them better? > > The only reason I added python and perl was because the fresh > install I > did with the i686 didn't have perl and python in. When I updated > it, it > worked but yeah I'll test it. > > Again appreciate the feedback I'll have a further play with it but > direction for reading would be appreciated :) Hi Marc, that's strange, the perl macros should be defined within rpm itself. What is your build environment like (are you running 'rpmbuild' directly? From which account? Which version of Fedora/ Redhat are you running?) Try running 'rpm --showrc | grep perl_' to see how the macros are defined. On an FC6 box, for example, I get: perl_sitelib %(eval "`%{__perl} -V:installsitelib`"; echo $installsitelib) And running the perl command listed gives me: $ perl -V:installsitelib installsitelib='/usr/lib/perl5/site_perl/5.8.8'; If you install the rpmdevtools package, you should see some spec file templates in /etc/rpmdevtools/ which may help. See the perl and python specs specifically. -Jeff From marc at mwiriadi.id.au Sun Jun 10 13:14:27 2007 From: marc at mwiriadi.id.au (Marc Wiriadisastra) Date: Sun, 10 Jun 2007 21:14:27 +0800 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: <4A5B4050-B3C9-4D87-88E1-68B85218F75A@cs.ucsb.edu> References: <1181449193.29027.1.camel@localhost.localdomain> <1181451166.29027.3.camel@localhost.localdomain> <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> <1181478307.4772.4.camel@localhost.localdomain> <4A5B4050-B3C9-4D87-88E1-68B85218F75A@cs.ucsb.edu> Message-ID: <1181481267.4772.8.camel@localhost.localdomain> On Sun, 2007-06-10 at 09:10 -0400, Jeff Sheltren wrote: > On Jun 10, 2007, at 8:25 AM, Marc Wiriadisastra wrote: > > > > I appreciate the feedback Jeff. I'm getting errors relating to the > > following perl macro's placed in the %file section. > > > > RPM build errors: > > File must begin with "/": %{_perl_sitelib}/* > > File must begin with "/": %{_perl_vendorlib}/perllocal.pod > > File must begin with "/": %{_perl_vendorarch}/auto/adesklets/ > > File must begin with "/": > > %{_perl_vendorarch}/auto/adesklets/.packlist > > > > Also the RPM that I created before with the SPEC file that I > > emailed to > > the list compiled and created the RPM I installed it and ran the > > resultant program and I couldn't get it to segfault. Not that I > > tested > > it to thoroughly. > > > > Do you have a link to the explaining of the macro's so I can > > understand > > them better? > > > > The only reason I added python and perl was because the fresh > > install I > > did with the i686 didn't have perl and python in. When I updated > > it, it > > worked but yeah I'll test it. > > > > Again appreciate the feedback I'll have a further play with it but > > direction for reading would be appreciated :) > > Hi Marc, that's strange, the perl macros should be defined within rpm > itself. What is your build environment like (are you running > 'rpmbuild' directly? From which account? Which version of Fedora/ > Redhat are you running?) Try running 'rpm --showrc | grep perl_' to > see how the macros are defined. On an FC6 box, for example, I get: > perl_sitelib %(eval "`%{__perl} -V:installsitelib`"; echo > $installsitelib) > And running the perl command listed gives me: > $ perl -V:installsitelib > installsitelib='/usr/lib/perl5/site_perl/5.8.8'; > > If you install the rpmdevtools package, you should see some spec file > templates in /etc/rpmdevtools/ which may help. See the perl and > python specs specifically. > > -Jeff I am using the rpmbuild as a local user. I used the scripts to create the rpmbuild directories. [marc at Strikelap SPECS]$ rpm --showrc | grep perl_ -14: __perl_provides /usr/lib/rpm/perl.prov -14: __perl_requires /usr/lib/rpm/perl.req -14: perl_archlib %(eval "`%{__perl} -V:installarchlib`"; echo $installarchlib) -14: perl_privlib %(eval "`%{__perl} -V:installprivlib`"; echo $installprivlib) -14: perl_sitearch %(eval "`%{__perl} -V:installsitearch`"; echo $installsitearch) -14: perl_sitelib %(eval "`%{__perl} -V:installsitelib`"; echo $installsitelib) -14: perl_vendorarch %(eval "`%{__perl} -V:installvendorarch`"; echo $installvendorarch) -14: perl_vendorlib %(eval "`%{__perl} -V:installvendorlib`"; echo $installvendorlib) Thanks for the info I found some references for the python on the wiki since my email. I'll have a play with it and see where I'm stuffing up. Cheers again, Marc From sheltren at cs.ucsb.edu Sun Jun 10 13:31:54 2007 From: sheltren at cs.ucsb.edu (Jeff Sheltren) Date: Sun, 10 Jun 2007 09:31:54 -0400 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: <1181481267.4772.8.camel@localhost.localdomain> References: <1181449193.29027.1.camel@localhost.localdomain> <1181451166.29027.3.camel@localhost.localdomain> <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> <1181478307.4772.4.camel@localhost.localdomain> <4A5B4050-B3C9-4D87-88E1-68B85218F75A@cs.ucsb.edu> <1181481267.4772.8.camel@localhost.localdomain> Message-ID: <05B8D884-B38D-472D-9231-3C0A1CDB5739@cs.ucsb.edu> On Jun 10, 2007, at 9:14 AM, Marc Wiriadisastra wrote: > > I'll have a play with it and see where I'm stuffing up. > > Cheers again, > > Marc Hi Marc, sorry, I messed up with the spec I sent you. The % {perl_sitelib}, etc. macros should *not* have a leading underscore in front of them. :) Try removing the leading '_' from the perl/python macros. -Jeff From marc at mwiriadi.id.au Sun Jun 10 13:53:41 2007 From: marc at mwiriadi.id.au (Marc Wiriadisastra) Date: Sun, 10 Jun 2007 21:53:41 +0800 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: <05B8D884-B38D-472D-9231-3C0A1CDB5739@cs.ucsb.edu> References: <1181449193.29027.1.camel@localhost.localdomain> <1181451166.29027.3.camel@localhost.localdomain> <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> <1181478307.4772.4.camel@localhost.localdomain> <4A5B4050-B3C9-4D87-88E1-68B85218F75A@cs.ucsb.edu> <1181481267.4772.8.camel@localhost.localdomain> <05B8D884-B38D-472D-9231-3C0A1CDB5739@cs.ucsb.edu> Message-ID: <1181483621.4772.11.camel@localhost.localdomain> On Sun, 2007-06-10 at 09:31 -0400, Jeff Sheltren wrote: > On Jun 10, 2007, at 9:14 AM, Marc Wiriadisastra wrote: > > > > I'll have a play with it and see where I'm stuffing up. > > > > Cheers again, > > > > Marc > > Hi Marc, sorry, I messed up with the spec I sent you. The % > {perl_sitelib}, etc. macros should *not* have a leading underscore in > front of them. :) Try removing the leading '_' from the perl/python > macros. > > -Jeff Well it all works. Attached is the updated spec file. I'll test it a little bit and see if I can get it to segfault. I'm not sure if I need to package the additional parts to adesklets since you can download them using the adesklets_installer. Cheers, Marc -------------- next part -------------- A non-text attachment was scrubbed... Name: adesklets.spec Type: text/x-rpm-spec Size: 1517 bytes Desc: not available URL: From marc at mwiriadi.id.au Sun Jun 10 14:07:37 2007 From: marc at mwiriadi.id.au (Marc Wiriadisastra) Date: Sun, 10 Jun 2007 22:07:37 +0800 Subject: [Fedora-mentors-list] adesklets.spec In-Reply-To: <1181483621.4772.11.camel@localhost.localdomain> References: <1181449193.29027.1.camel@localhost.localdomain> <1181451166.29027.3.camel@localhost.localdomain> <85456F5E-0AE4-4D29-8382-961A2E6DE95C@cs.ucsb.edu> <1181478307.4772.4.camel@localhost.localdomain> <4A5B4050-B3C9-4D87-88E1-68B85218F75A@cs.ucsb.edu> <1181481267.4772.8.camel@localhost.localdomain> <05B8D884-B38D-472D-9231-3C0A1CDB5739@cs.ucsb.edu> <1181483621.4772.11.camel@localhost.localdomain> Message-ID: <1181484457.4772.14.camel@localhost.localdomain> On Sun, 2007-06-10 at 21:53 +0800, Marc Wiriadisastra wrote: > On Sun, 2007-06-10 at 09:31 -0400, Jeff Sheltren wrote: > > On Jun 10, 2007, at 9:14 AM, Marc Wiriadisastra wrote: > > > > > > I'll have a play with it and see where I'm stuffing up. > > > > > > Cheers again, > > > > > > Marc > > > > Hi Marc, sorry, I messed up with the spec I sent you. The % > > {perl_sitelib}, etc. macros should *not* have a leading underscore in > > front of them. :) Try removing the leading '_' from the perl/python > > macros. > > > > -Jeff > > Well it all works. > > Attached is the updated spec file. I'll test it a little bit and see if > I can get it to segfault. > > I'm not sure if I need to package the additional parts to adesklets > since you can download them using the adesklets_installer. > > Cheers, > > Marc Ok I'm not sure if this is a bug but according to the following page if Python is compiled 'to aggressively' then adesklets won't work. http://adesklets.sourceforge.net/doc/en/Frequently-asked-questions.html Would this be a bug? I cannot run any Python-based desklet: I get garbage collection errors! If you get errors similar to: python: Modules/gcmodule.c:275: visit_decref: Assertion `gc->gc.gc_refs != 0' failed. Aborted It means your installment of Python has a corrupted garbage collector; it is often caused by incorrect or aggressive optimization during the compilation. Just recompiling a stock python environment from http://python.org/ usually solves this. Since just testing the desklet causes that issue? Cheers, Marc