F11 for the X01- shutdown

[James Cameron]

On Sat, Aug 01, 2009 at 12:00:19AM +0545, Daniel Drake wrote:
> 2009/7/31 James Cameron <quozl at laptop.org>:
> > Where can I find the src.rpm and the upstream source?
> 
> It's a standard Fedora package.

Bugger.  I always get that answer, and it never satisfies.  I'm stalled,
unable to find the src.rpm and the upstream source, I ask, and someone
says "it's a Fedora package", as if to say "you ought to know and I'm
not going to tell you what you need to know to proceed."  ;-)

> Your diff is correct but I see a 2nd bug too: the return value of
> check_stolen_hash is never checked.
> 
> handmade diff for you to test:
> 
> -    if isxo and 'stolen' in resp_map:
> -       check_stolen_hash(resp_map['stolen'], uuid, nonce)
> +    if isxo and 'stolen' in resp_map and
> check_stolen_hash(resp_map['stolen'], uuid, nonce):
>  # this machine has been reported stolen - get rid of
> 
> let me know if you need more details...

That fixed it.  Running olpc-update-query manually no longer reports the
machine as stolen.

The change was:

--- olpc-update-query.orig      2009-07-31 23:02:51.000000000 -0400
+++ olpc-update-query   2009-07-31 23:02:31.000000000 -0400
@@ -190,8 +190,8 @@
     if 'nonce' not in resp_map or nonce != resp_map['nonce']:
         raise RuntimeError('bad nonce in reply')
 
-    if isxo and 'stolen' in resp_map:
-        check_stolen_hash(resp_map['stolen'], uuid, nonce)
+    if isxo and 'stolen' in resp_map and \
+        check_stolen_hash(resp_map['stolen'], uuid, nonce):
         # this machine has been reported stolen - get rid of
         # any leases and poweroff
         if os.path.exists(LEASE_FILE):

-- 
James Cameron
http://quozl.linux.org.au/