[Bug 188974] Review Request: libGLw

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libGLw


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188974





------- Additional Comments From pertusus at free.fr  2006-04-14 19:05 EST -------
(In reply to comment #4)

> That feels like such overkill.  I'll give it a shot though.

If you speak about the idea of a script to remove the file, I agree
but if it is about removing the file I disagree. A non free file
cannot be included in a fedora extra srpm.

http://fedoraproject.org/wiki/ForbiddenItems#head-0977d53a9aaae33e484bc92e8504bf0a3ef85e52

> No, they can't.  This battle has been fought and lost before.  We already slice
> up the default build of Mesa, since we don't use its libglut for being non-free.

It is not slicing, it is removing a non free part. But anyway I don't
feel competent enough for this issue to have an interesting point of
view - and because of that issue I don't want to assign that bug to me.
But somebody with an idea on that subject may come and advise, otherwise
I believe it should be an interesting issue to post on the fedora-extras 
list.

> Other changes applied, along with some fixed %package statements to make the
> binary rpm not be named libGLw-libGLw-*.  New versions uploaded to the same URLs
> as before.

It may be better to bump the release and provide a new srpm, 
with a changelog entry stating the differences coming from the 
review process except when changes are very small. You can have a
look at other fedora extras review for examples.

I'll try to comment on all the other issues, however. Here are 
the comments:

* remove the server name (internap) from the source url
* with_dri isn't set anywhere... It certainly should be 0 or 1.
  As is, it leads to an error in the target script:
++ ./redhat-mesa-target '%{with_dri}' i386
./redhat-mesa-target: line 14: [: %{with_dri}: integer expression expected
* currently the mesa-6.5-build-config.patch doesn't lead to
  the wanted effects, because, due to the error above, the 
  configs/linux file is used instead of configs/linux-dri
* the CFLAGS used are not those from the RPM_OPT_FLAGS, but those 
  defined in configs/linux. Maybe the CFLAGS line should be removed 
  in the mesa-6.5-build-config.patch (whatever the right file config
  file is).
* rpmlint complains that in my opinion should be acted upon:
W: libGLw summary-ended-with-dot Xaw / Motif OpenGL widgets.
W: libGLw incoherent-version-in-changelog 6.5-1 1.0-1
E: libGLw-devel obsolete-not-provided Mesa-devel
E: libGLw-devel obsolete-not-provided XFree86-devel
E: libGLw-devel obsolete-not-provided xorg-x11-devel
E: libGLw-devel no-ldconfig-symlink /usr/lib/libGLw.so

* rpmlint complains that should in my opinion be ignored:
W: libGLw invalid-license MIT/X11
W: libGLw strange-permission redhat-mesa-target 0755

* Are the Obsolete really necessary?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.