[Bug 185288] Review Request: libchmxx - C++ bindings for chmlib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libchmxx - C++ bindings for chmlib


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=185288


bugzilla at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          QAContact|fedora-extras-              |fedora-package-
                   |list at redhat.com             |review at redhat.com

jpmahowald at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|bugzilla-sink at leemhuis.info |jpmahowald at gmail.com
OtherBugsDependingO|163776                      |163778
              nThis|                            |




------- Additional Comments From jpmahowald at gmail.com  2006-04-18 00:26 EST -------
- rpmlint checks return:
W: libchmxx-debuginfo objdump-failed
E: libchmxx-devel only-non-binary-in-usr-lib
symlink, can ignore

You need a %defattr on %files devel

- package meets naming guidelines
- package meets packaging guidelines
- license ([L]GPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file


- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r

Looking good otherwise.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.