[Bug 188625] Review Request: AllegroOgg - Ogg library for use with the Allegro game library

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 19 00:01:14 UTC 2006


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: AllegroOgg - Ogg library for use with the Allegro game library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=188625


wart at kobold.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163776                      |163779
              nThis|                            |




------- Additional Comments From wart at kobold.org  2006-04-18 20:01 EST -------
MUST
====
* rmplint output:
W: AllegroOgg-devel no-documentation
docs are included in the base package; this warning can be ignored.

* Package name acceptible (see earlier discussion)
* Spec file name matches package name
* Source matches upstream
  b4e99081acdb4bedb3206bdfb3b4d209  alogg.zip
* BSD license ok, license file included
* Spec file legible and in Am. English
* Package builds in mock on multiple platforms:
  FC4-i386, FC4-x86_64, FC5-i386, FC5-x86_64
* BR ok with one exception (see below)
* No Locales
* ldconfig called for shared libs
* Not relocatable
* Doesn't create any directories that it needs to own
* No duplicate %files
* header files and .so (no suffix) live in -devel package
* No .desktop file needed
* No .la files included
* -devel requires base package

MUSTFIX
=======
* libogg-devel is already required by libvorbis-devel

The blocker is minor, so feel free to remove it after importing.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.




More information about the Fedora-package-review mailing list